Date: Sat, 21 Aug 1999 09:43:31 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: "Brian F. Feldman" <green@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_physio.c Message-ID: <11658.935221411@critter.freebsd.dk> In-Reply-To: Your message of "Sat, 21 Aug 1999 00:26:29 PDT." <Pine.BSF.4.10.9908210025480.55604-100000@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <Pine.BSF.4.10.9908210025480.55604-100000@freefall.freebsd.org>, "Brian F. Feldman" writes:
>On Fri, 20 Aug 1999, Poul-Henning Kamp wrote:
>
>> phk 1999/08/20 23:48:17 PDT
>>
>> Modified files:
>> sys/kern kern_physio.c
>> Log:
>> Detect if the the offset used to read from a raw device loose bits
>> when converted to block number.
>>
>> Revision Changes Path
>> 1.37 +8 -2 src/sys/kern/kern_physio.c
>
>- bp->b_blkno = btodb(uio->uio_offset);
>+ blockno = uio->uio_offset >> DEV_BSHIFT;
>+ bp->b_blkno = blockno;
>+ if (bp->b_blkno != blockno) {
> ^- How can this comparison ever fail?
They're different sizes.
--
Poul-Henning Kamp FreeBSD coreteam member
phk@FreeBSD.ORG "Real hackers run -current on their laptop."
FreeBSD -- It will take a long time before progress goes too far!
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?11658.935221411>