Date: Mon, 13 Jan 2014 09:34:39 +0100 From: John Marino <freebsd.contact@marino.st> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, TAKATSU Tomonari <tota@FreeBSD.org> Subject: Re: svn commit: r338361 - in head/devel/silentbob: . files Message-ID: <52D3A51F.8080709@marino.st> In-Reply-To: <20140113082949.GB8735@FreeBSD.org> References: <201401010649.s016nJ4w004860@svn.freebsd.org> <20140113082949.GB8735@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/13/2014 09:29, Alexey Dokuchaev wrote: > On Wed, Jan 01, 2014 at 06:49:19AM +0000, TAKATSU Tomonari wrote: >> New Revision: 338361 >> URL: http://svnweb.freebsd.org/changeset/ports/338361 >> >> +PORTDOCS= README > [...] >> +.if ${PORT_OPTIONS:MDOCS} >> post-install: >> -.if !defined(NOPORTDOCS) >> - @${MKDIR} ${DOCSDIR} >> - @${INSTALL_DATA} ${WRKSRC}/README ${DOCSDIR} >> - @${INSTALL_DATA} ${WRKSRC}/doc/* ${DOCSDIR} >> + @${MKDIR} ${STAGEDIR}${DOCSDIR} >> + @${INSTALL_DATA} ${WRKSRC}/${PORTDOCS} ${STAGEDIR}${DOCSDIR} > > For a simple cases like this one (when docs are not being built and are just > a lonely README file), once staged, .if ${PORT_OPTIONS:MDOCS} is no longer > necessary (and would allow you to remove .include <bsd.port.options.mk>). > > Please note that INSTALL_* commands should not be muted (muting MKDIR is > fine), thank you. On the latter, maybe it would be worth your time to modify portlint to flag muted install commands in the install and post-install targets? stage targets too.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52D3A51F.8080709>