Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 20 Mar 2021 01:42:17 GMT
From:      Alan Somers <asomers@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 9c5aac8f2e84 - main - fusefs: fix a dead store in fuse_vnop_advlock
Message-ID:  <202103200142.12K1gHmv016001@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by asomers:

URL: https://cgit.FreeBSD.org/src/commit/?id=9c5aac8f2e84ca4bbdf82514302c08c0453ec59b

commit 9c5aac8f2e84ca4bbdf82514302c08c0453ec59b
Author:     Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2021-03-20 01:38:57 +0000
Commit:     Alan Somers <asomers@FreeBSD.org>
CommitDate: 2021-03-20 01:38:57 +0000

    fusefs: fix a dead store in fuse_vnop_advlock
    
    kevans actually caught this in the original review and I fixed it, but
    then I committed an older copy of the branch.  Whoops.
    
    Reported by:    kevans
    MFC after:      13 days
    MFC with:       929acdb19acb67cc0e6ee5439df98e28a84d4772
    Differential Revision:  https://reviews.freebsd.org/D29031
---
 sys/fs/fuse/fuse_vnops.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sys/fs/fuse/fuse_vnops.c b/sys/fs/fuse/fuse_vnops.c
index cdbc42f5adf4..a51c1b15e7f0 100644
--- a/sys/fs/fuse/fuse_vnops.c
+++ b/sys/fs/fuse/fuse_vnops.c
@@ -444,7 +444,6 @@ fuse_vnop_advlock(struct vop_advlock_args *ap)
 		break;
 	case F_UNLCK:
 		op = FUSE_SETLK;
-		flags |= F_UNLCK;
 		break;
 	default:
 		return EINVAL;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202103200142.12K1gHmv016001>