Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Apr 2009 14:15:10 +0000 (UTC)
From:      Paolo Pisati <piso@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r190923 - user/piso/ipfw/sys/netinet/libalias
Message-ID:  <200904111415.n3BEFAZk088475@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: piso
Date: Sat Apr 11 14:15:09 2009
New Revision: 190923
URL: http://svn.freebsd.org/changeset/base/190923

Log:
  In case of malformed packets (or some other unrecoverable error), toss the packet: fix a but introduced in rev 1.20.

Modified:
  user/piso/ipfw/sys/netinet/libalias/alias_nbt.c

Modified: user/piso/ipfw/sys/netinet/libalias/alias_nbt.c
==============================================================================
--- user/piso/ipfw/sys/netinet/libalias/alias_nbt.c	Sat Apr 11 14:13:39 2009	(r190922)
+++ user/piso/ipfw/sys/netinet/libalias/alias_nbt.c	Sat Apr 11 14:15:09 2009	(r190923)
@@ -93,8 +93,7 @@ static int 
 protohandler1(struct libalias *la, struct ip *pip, struct alias_data *ah)
 {
 	
-	AliasHandleUdpNbt(la, pip, ah->lnk, ah->aaddr, *ah->aport);
-	return (0);
+	return (AliasHandleUdpNbt(la, pip, ah->lnk, ah->aaddr, *ah->aport));
 }
 
 static int 
@@ -123,9 +122,8 @@ static int 
 protohandler2out(struct libalias *la, struct ip *pip, struct alias_data *ah)
 {
 	
-	AliasHandleUdpNbtNS(la, pip, ah->lnk, &pip->ip_src, ah->sport,
- 			    ah->aaddr, ah->aport);
-	return (0);
+	return (AliasHandleUdpNbtNS(la, pip, ah->lnk, &pip->ip_src, ah->sport,
+ 	    ah->aaddr, ah->aport));
 }
 
 /* Kernel module definition. */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200904111415.n3BEFAZk088475>