Date: Mon, 30 Jan 2017 19:05:08 +0100 From: Matthias Andree <mandree@FreeBSD.org> To: marino@freebsd.org, Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r432789 - in head/graphics: rawtherapee rawtherapee-devel Message-ID: <d9644907-265c-291d-1713-1d08df05970a@FreeBSD.org> In-Reply-To: <26beab27-ea3b-6891-69ee-ebadd071013f@marino.st> References: <201701291734.v0THYrKF093793@repo.freebsd.org> <5a60e31f-dfbe-708b-91ac-c8ac2c9d8dc8@FreeBSD.org> <26beab27-ea3b-6891-69ee-ebadd071013f@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 30.01.2017 um 14:20 schrieb John Marino:
> On 1/30/2017 03:07, Mathieu Arnold wrote:
>> Le 29/01/2017 à 18:34, Matthias Andree a écrit :
>>> +.if ${OSVERSION} < 1030000
>>> +IGNORE= is only for supported FreeBSD releases
>>> +.endif
>>
>>> +.if ${OSVERSION} < 1030000
>>> +IGNORE= is only for supported FreeBSD releases
>>> +.endif
>>
>>
>> The ports framework already has a check for unsupported releases, these
>> are not needed.
>>
>
> With a caveat. The ports framework is overrideable with
> ALLOW_UNSUPPORTED_SYSTEMS and this one is not. Morever, rawtherapee may
> specifically draw the line at 10.3 and not "unsupported releases". I
> guess only mandree knows for sure.
Thanks for this discussion, Mathieu and John.
Basically the idea was to kill building on unsupported systems, so I
will remove this duplicate code next time I commit. No need to
duplicate code. If someone requests the port to force build on an
unsupported system, any PRs that come my way to ask for support for
decommissioned or deprecated systems will be closed as "rejected"
anyhow, so...
Dim@ answered on the "FreeBSD 12 i386 GCC" combo with a "don't expect
upstream" support... so I wonder if it's our ABI, but I don't mean to
take on yet another project.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d9644907-265c-291d-1713-1d08df05970a>