Date: Wed, 17 Aug 2011 16:52:30 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: freebsd-fs@freebsd.org, onwahe@gmail.com Subject: Re: NFS calculation of max commit size Message-ID: <20110817135230.GW17489@deviant.kiev.zoral.com.ua> In-Reply-To: <1313769356.247298.1313586915280.JavaMail.root@erie.cs.uoguelph.ca> References: <20110817012806.GA29555@icarus.home.lan> <1313769356.247298.1313586915280.JavaMail.root@erie.cs.uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--DTWYra+TaQJg/4dl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 17, 2011 at 09:15:15AM -0400, Rick Macklem wrote: >=20 > I think that any fraction of hibufspace should be sufficient to avoid > the deadlock. Also, since the buffer cache code doesn't use vnode locking > these days, I'm not even sure if write backs are blocked by the wrire > vnode op in progress. (ie. I'm not sure the deadlock it originally fixed > would still happen without it.) bufdaemon definitely acquires vnode lock when flushing dirty buffer, this was a problem on its own. I think you refer to the nfsiod operation. There is another op that is performed without holding the vnode lock consistently from (old)nfs code, namely, truncation. It would be useful to fix this. Please see r188386. --DTWYra+TaQJg/4dl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk5Lx54ACgkQC3+MBN1Mb4irygCgntPbEsHt+JVa1uL9BfJzv4Lz EBkAoORNKVitJTHM8xVseUyPQvSzpi1N =FgyM -----END PGP SIGNATURE----- --DTWYra+TaQJg/4dl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110817135230.GW17489>