Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 18 Nov 2002 20:45:24 +0100
From:      =?ISO-8859-1?Q?Joachim_Str=F6mbergson?= <watchman@ludd.luth.se>
To:        FreeBSD-Audit <audit@FreeBSD.ORG>
Subject:   Removal of includes of strings.h
Message-ID:  <3DD94354.5040506@ludd.luth.se>

next in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format.
--------------020700070409020704070601
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit

Aloha!

Strings.h in FreeBSD is simply defined as: #include <string.h>

Applications should instead use string.h directly. This was fixed in dd.

I submitted a similar patch för rusers in June. I have been in contact
with Giorgos and he suggested that I should submit similar patches for
other programs to FreeBSD-Audit.

This mail contains the rusers patch (again) and patches for mount_nfs
and ncplogin.

All patches are against STABLE.

Comments? Commits?

-- 
Med vänlig hälsning, Cheers!

Joachim Strömbergson
============================================================================
Joachim Strömbergson - ASIC designer, nice to *cute* animals.
    snail:                  phone:                     mail & web:
Sävenäsgatan 5A        +46 31 - 27 98 47          watchman@ludd.luth.se
416 72 Göteborg        +46 733 75 97 02           www.ludd.luth.se/~watchman
============================================================================

--------------020700070409020704070601
Content-Type: text/plain;
 name="mount_nfs.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="mount_nfs.diff"

--- /usr/src/sbin/mount_nfs/mount_nfs.c	Wed Aug 14 11:57:20 2002
+++ mount_nfs.c	Fri Nov 15 08:25:44 2002
@@ -75,7 +75,7 @@
 #include <netdb.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <strings.h>
+#include <string.h>
 #include <sysexits.h>
 #include <unistd.h>
 

--------------020700070409020704070601
Content-Type: text/plain;
 name="ncplogin.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ncplogin.diff"

--- /usr/src/usr.bin/ncplogin/ncplogin.c	Sun Oct 31 03:14:59 1999
+++ ncplogin.c	Fri Nov 15 08:21:23 2002
@@ -37,7 +37,7 @@
 #include <err.h>
 #include <stdio.h>
 #include <unistd.h>
-#include <strings.h>
+#include <string.h>
 #include <stdlib.h>
 #include <sysexits.h>
 

--------------020700070409020704070601
Content-Type: text/plain;
 name="rusers.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="rusers.diff"

--- /usr/src/usr.bin/rusers/rusers.c	Wed Jul  4 22:20:31 2001
+++ rusers.c	Fri Nov 15 08:23:19 2002
@@ -46,7 +46,7 @@
 #include <netdb.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <strings.h>
+#include <string.h>
 #include <unistd.h>
 
 #define MAX_INT		0x7fffffff

--------------020700070409020704070601--


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3DD94354.5040506>