Date: Wed, 6 Oct 2010 23:15:09 +0200 (CEST) From: Jilles Tjoelker <jilles@stack.nl> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/151270: [PATCH] multimedia/xfce4-parole: explicitly disable browser plugin Message-ID: <20101006211509.8958B17312@turtle.stack.nl> Resent-Message-ID: <201010062120.o96LK14O091428@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 151270 >Category: ports >Synopsis: [PATCH] multimedia/xfce4-parole: explicitly disable browser plugin >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Oct 06 21:20:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Jilles Tjoelker >Release: FreeBSD 9.0-CURRENT >Organization: MCGV Stack >Environment: 9-CURRENT with patched sh(1) >Description: The upstream configure script contains broken code in the detection for the browser plugin: BROWSER_PLUGIN_DIR="${BROWSER_PLUGIN_DIR:-"\${libdir}/mozilla/plugins"}" POSIX does not require this to work and many shells such as the current FreeBSD /bin/sh as of the time of writing silently assign an incorrect value. (Some shells such as dash even flag a syntax error.) I plan to change our sh to do what is expected by the author (assign the literal string ${libdir}/mozilla/plugins if BROWSER_PLUGIN_DIR is not set yet). This is both because bash and ksh93 do the same thing and because it is otherwise much harder to make splitting WORD in ${VAR+WORD} work in a consistent manner (the change enforces that each substitution ends with the same double-quote state as it started). This change, however, causes the browser plugin to be built, which subsequently causes a pointyhat failure because the browser plugin's files are not in the plist. To fix this, I suggest explicitly disabling the browser plugin via --disable-browser-plugin. Upstream has removed the browser plugin entirely in their 0.2.2 branch, although there is no release yet with this change. I would like to commit the sh changes before that release. >How-To-Repeat: Build/install the port with patched sh. The patch (to head r212508) is available at http://www.stack.nl/~jilles/unix/sh-expand-parser-20100919.patch until I commit it to 9-CURRENT. >Fix: Apply this patch. --- multimedia-xfce4-parole-disable-browser-plugin.patch begins here --- --- ports/multimedia/xfce4-parole/Makefile.orig 2010-05-31 17:27:25.000000000 +0200 +++ ports/multimedia/xfce4-parole/Makefile 2010-10-06 22:40:52.000000000 +0200 @@ -23,7 +23,7 @@ USE_BZIP2= yes USE_GSTREAMER= ffmpeg good theora xvid mp3 faad ogg dvd x264 USE_GMAKE= yes -CONFIGURE_ARGS= --disable-power-manager-plugin +CONFIGURE_ARGS= --disable-power-manager-plugin --disable-browser-plugin CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" LDFLAGS="-L${LOCALBASE}/lib" USE_GNOME= gnomehack intltool intlhack pkgconfig USE_XFCE= configenv libexo libgui libutil panel --- multimedia-xfce4-parole-disable-browser-plugin.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101006211509.8958B17312>