Date: Tue, 31 May 2016 14:17:31 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Philippe Audeoud <jadawin@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r416200 - head/net/spoofer Message-ID: <20160531141731.GA69709@FreeBSD.org> In-Reply-To: <201605311358.u4VDwiPq037072@repo.freebsd.org> References: <201605311358.u4VDwiPq037072@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 31, 2016 at 01:58:44PM +0000, Philippe Audeoud wrote: > New Revision: 416200 > URL: https://svnweb.freebsd.org/changeset/ports/416200 > > Log: > - Fix indent > > Noticed by: danfe Thanks, but see below. > [...] > -GNU_CONFIGURE= yes > +GNU_CONFIGURE= yes > CONFIGURE_ARGS+= --disable-development This is initial assignment, += is not warranted. > -OPTIONS_DEFINE= DOCS GUI > +OPTIONS_DEFINE= DOCS GUI > OPTIONS_DEFAULT= GUI > -OPTIONS_SUB= yes > +OPTIONS_SUB= yes > > .include <bsd.port.options.mk> Consider converting the block below to options helper knobs and get rid of .include <bsd.port.options.mk>. > .if ${PORT_OPTIONS:MGUI} > -USE_QT5= buildtools_build qmake_build core network gui widgets > -USE_GL+= gl > -USE_RC_SUBR= ${PORTNAME} > +USE_QT5= buildtools_build qmake_build core network gui widgets > +USE_GL+= gl > +USE_RC_SUBR= ${PORTNAME} > .else > CONFIGURE_ARGS+= --disable-manager > .endif > > do-install-DOCS-on: > - ${MKDIR} ${STAGEDIR}${DOCSDIR} > +${MKDIR} ${STAGEDIR}${DOCSDIR} This one is wrong, ${MKDIR} is part of the recipe. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160531141731.GA69709>