Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Sep 2010 13:38:24 +0200 (CEST)
From:      Guido Falsi <mad@madpilot.net>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        gnome@FreeBSD.org
Subject:   [patch]: make the dependency on gnucash-docs conditional
Message-ID:  <20100927113824.10B231EED@megatron.madpilot.net>

next in thread | raw e-mail | index | archive | help

>Submitter-Id:	current-users
>Originator:	Guido Falsi
>Organization:	none
>Confidential:	no
>Synopsis:	[patch]: make the dependency on gnucash-docs conditional
>Severity:	non-critical
>Priority:	low
>Category:	ports
>Class:		change-request
>Release:	FreeBSD 8.1-STABLE amd64
>Environment:
System: FreeBSD megatron.madpilot.net 8.1-STABLE FreeBSD 8.1-STABLE #22: Tue Sep 21 19:13:06 CEST 2010 root@megatron.madpilot.net:/usr/obj/usr/src/sys/MEGATRON amd64

>Description:

Since the gnucash-docs port pulls in a lot of dependencies which
are not needed to make gnucash itself run, I would like to be able
to not install it.

I have manually removed that depends line every time I've updated
gnucash for years. I thought I could send a patch and ask for it
to be included.

I bumped portrevision since this change modifies the port options
and, potentially, it's dependencies.

The gnome@ list, which is the maintainer is CCed.

>How-To-Repeat:

>Fix:

diff -ruN gnucash.old/Makefile gnucash/Makefile
--- gnucash.old/Makefile	2010-08-24 18:07:59.060646788 +0200
+++ gnucash/Makefile	2010-09-27 13:34:39.266665930 +0200
@@ -8,7 +8,7 @@
 
 PORTNAME=	gnucash
 PORTVERSION=	2.2.9
-PORTREVISION=	9
+PORTREVISION=	10
 CATEGORIES=	finance gnome
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}%20%28stable%29/${PORTVERSION} \
 		http://www.gnucash.org/pub/gnucash/sources/stable/
@@ -26,12 +26,12 @@
 		${SITE_PERL}/Date/Manip.pm:${PORTSDIR}/devel/p5-Date-Manip \
 		${SITE_PERL}/Finance/Quote.pm:${PORTSDIR}/finance/p5-Finance-Quote \
 		${SITE_PERL}/HTML/TableExtract.pm:${PORTSDIR}/www/p5-HTML-TableExtract \
-		${SITE_PERL}/Finance/QuoteHist.pm:${PORTSDIR}/finance/p5-Finance-QuoteHist \
-		${LOCALBASE}/share/omf/gnucash-docs/gnucash-guide-C.omf:${PORTSDIR}/finance/gnucash-docs
+		${SITE_PERL}/Finance/QuoteHist.pm:${PORTSDIR}/finance/p5-Finance-QuoteHist
 
 OPTIONS=	AQBANKING	"AqBanking support (HBCI/OpenHBCI)"	off	\
 		OFX		"OFX support"				off	\
-		POSTGRESQL	"Enable Postgresql as Backend"		off
+		POSTGRESQL	"Enable Postgresql as Backend"		off	\
+		GCDOCS		"Install gnucash-docs"			on
 
 USE_BZIP2=	yes
 USE_GETTEXT=	yes
@@ -102,6 +102,10 @@
 PLIST_SUB+=	PGBACKEND="@comment "
 .endif
 
+.if defined(WITH_GCDOCS)
+RUN_DEPENDS+=	${LOCALBASE}/share/omf/gnucash-docs/gnucash-guide-C.omf:${PORTSDIR}/finance/gnucash-docs
+.endif
+
 CONFIGURE_ENV+=	LIBS="${GC_LIBS}"
 
 .include <bsd.port.post.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100927113824.10B231EED>