Date: Thu, 28 Feb 2013 16:25:23 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Davide Italiano <davide@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r247460 - head/sys/dev/acpica Message-ID: <20130228162522.GA41693@FreeBSD.org> In-Reply-To: <201302281127.r1SBR2VE068276@svn.freebsd.org> References: <201302281127.r1SBR2VE068276@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 28, 2013 at 11:27:02AM +0000, Davide Italiano wrote: > New Revision: 247460 > URL: http://svnweb.freebsd.org/changeset/base/247460 > > Log: > MFcalloutng (r247427 by mav): > We don't need any precision here. Let it be fast and dirty shift then > slow and excessively precise 64-bit division. > > - if (sbt >= 0 && us > sbt / SBT_1US) > - us = sbt / SBT_1US; > + if (sbt >= 0 && us > (sbt >> 12)) > + us = (sbt >> 12); Does this really buy us anything? Modern compilers should be smart enough to generate correct code. Do you have evidence that this is not the case here? Not to mention that it obfuscates the code by using some magic constant. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130228162522.GA41693>