Date: Sun, 14 Mar 2010 13:23:32 -0700 From: Doug Barton <dougb@FreeBSD.org> To: =?UTF-8?B?QmVybmhhcmQgRnLDtmhsaWNo?= <decke@bluelife.at> Cc: cvs-ports@FreeBSD.org, Wesley Shields <wxs@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: Aw: Re: cvs commit: ports/www/redmine Makefile ports/www/redmine/files redmine.in Message-ID: <4B9D45C4.3090608@FreeBSD.org> In-Reply-To: <1268589378.8345.2.camel@Nokia-N900-42-11> References: <201003140407.o2E47fhJ063684@repoman.freebsd.org> <4B9C6C9E.3070902@FreeBSD.org> <1268589378.8345.2.camel@Nokia-N900-42-11>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------070102060205070203010508 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 03/14/10 10:56, Bernhard Fröhlich wrote: > ----- Ursprüngliche Mitteilung ----- >> On 03/13/10 20:07, Wesley Shields wrote: >>> wxs 2010-03-14 04:07:41 UTC >>> >>> FreeBSD ports repository >>> >>> Modified files: >>> www/redmine Makefile >>> Added files: >>> www/redmine/files redmine.in >>> Log: >>> - Add RC script. >>> >>> PR: ports/144299 >>> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=144299 Submitted by: Bernhard >>> Froehlich <decke@bluelife.at> (maintainer) >>> Revision Changes Path >>> 1.8 +6 -0 ports/www/redmine/Makefile >>> 1.1 +32 -0 ports/www/redmine/files/redmine.in (new) >>> >>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/Makefile.diff?&r1=1.7&r2=1.8&f=h >>> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/files/redmine.in >> >> There are several problems with this script. > > Thanks for your comment. I will have a look at the issues in the next few days. > >> 1. The REQUIRE line needs to be changed to LOGIN. This is preferred for >> all local scripts, but mandatory for those which run with a non-root >> [ug]id (which this one does). >> >> 2. Instead of command=%%RUBY_NAME%% it's likely you want to use >> command_interpreter instead. Does the stop command work with this script >> as it is currently? > > Yes it does work fine. I use it since a few months. The binary that is shown with top is ruby18 and RUBY_NAME is exactly that. My concern would be that for users with other versions of ruby installed it might not work, but if what you have works now (and no one more knowledgeable about ruby speaks up) then that's fine. >> 3. _flags should not be included in command_args, it will result in them >> being included twice. > > Oh did not know that the flags are automatically append to command_args. I will check and remove this then. Ok. >> 4. Are all of the options included in _flags actually things that a user >> might wish to twiddle? Should some of them be in command_args instead? > > Yes they are but the user should have no reason to change user and group so this could be moved to command_args. > >> 5. The pidfile location looks dubious to me, but I'm not sure if putting >> pid files in WWWDIR has somehow become routine? > > That is a bigger disussion because redmine is designed to work completely inside of his home directory and that includes scripts, pidfiles, tmp and everything else. I have already looked at spliting that up but decided against it because it would be a bad hack. I'm not willing to tilt at that windmill, so if anyone cares about this, speak up. :) >> 6. And finally a minor issue, %%RC_SUBR%% should just be /etc/rc.subr. >> I'll be making that change for all ports once the ports freeze is over, >> so no reason not to do it now. > > Did not know that either. When thinking about that issues it would have been good to have a few good examples or a documentation. Does that probably already exist and i just haven't found it? http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html > Thanks for your comments and i will also have a look at my other startscripts if they have the same problems. Ok. Meanwhile I've attached a patch for the current version with the non-controversial changes I mentioned above, and also Adding a $FreeBSD$, and using %%WWWDIR%% throughout instead of creating a variable for it. The SUB routine for the ports can handle as many substitutions of the same value as you need it to, and this way is (slightly) more efficient, and (slightly) less confusing. With your permission I'll commit this fix since Wesley is going to be traveling. hth, Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ --------------070102060205070203010508 Content-Type: text/plain; name="redmine.in.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="redmine.in.diff" SW5kZXg6IHJlZG1pbmUuaW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2hvbWUvcGN2cy9w b3J0cy93d3cvcmVkbWluZS9maWxlcy9yZWRtaW5lLmluLHYKcmV0cmlldmluZyByZXZpc2lv biAxLjEKZGlmZiAtdSAtcjEuMSByZWRtaW5lLmluCi0tLSByZWRtaW5lLmluCTE0IE1hciAy MDEwIDA0OjA3OjQxIC0wMDAwCTEuMQorKysgcmVkbWluZS5pbgkxNCBNYXIgMjAxMCAyMDox NzoxMCAtMDAwMApAQCAtMSw3ICsxLDkgQEAKICMhL2Jpbi9zaAogCisjICRGcmVlQlNEJAor CiAjIFBST1ZJREU6IHJlZG1pbmUKLSMgUkVRVUlSRTogREFFTU9OCisjIFJFUVVJUkU6IExP R0lOCiAjIEtFWVdPUkQ6IHNodXRkb3duCiAKICMgQWRkIHRoZSBmb2xsb3dpbmcgbGluZSB0 byAvZXRjL3JjLmNvbmZbLmxvY2FsXSB0byBlbmFibGUgcmVkbWluZQpAQCAtMTAsMjMgKzEy LDIyIEBACiAjICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNldCBpdCB0byAiWUVT IiB0byBlbmFibGUgcmVkbWluZS4KICMgcmVkbWluZV9mbGFncyAoc3RyKTogICAgICAgICAg Q3VzdG9tIGFkZGl0aW9uYWwgYXJndW1lbnRzIHRvIGJlIHBhc3NlZAogIyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB0byByZWRtaW5lLgotIwogCi0uICUlUkNfU1VCUiUlCisu IC9ldGMvcmMuc3VicgogCiBuYW1lPSJyZWRtaW5lIgogcmN2YXI9YHNldF9yY3ZhcmAKIGNv bW1hbmQ9JSVSVUJZX05BTUUlJQotcmVkbWluZV9ob21lPSIlJVdXV0RJUiUlIgotcGlkZmls ZT0iJHtyZWRtaW5lX2hvbWV9L3RtcC9waWRzL3RoaW4ucGlkIgorCitwaWRmaWxlPSIlJVdX V0RJUiUlL3RtcC9waWRzL3RoaW4ucGlkIgogCiBsb2FkX3JjX2NvbmZpZyAkbmFtZQogCiAj IHNldCBkZWZhdWx0cwogOiAke3JlZG1pbmVfZW5hYmxlPSJOTyJ9Ci06ICR7cmVkbWluZV9m bGFncz0iLWEgMC4wLjAuMCAtcCAzMDAwIC1lIHByb2R1Y3Rpb24gLXUgd3d3IC1nIHd3dyJ9 Cis6ICR7cmVkbWluZV9mbGFncz0iLWEgMC4wLjAuMCAtcCAzMDAwIC1lIHByb2R1Y3Rpb24i fQogCi1jb21tYW5kX2FyZ3M9Ii1kIC1EIC1jICR7cmVkbWluZV9ob21lfSAke3JlZG1pbmVf ZmxhZ3N9IgorY29tbWFuZF9hcmdzPSItZCAtRCAtYyAlJVdXV0RJUiUlIC11IHd3dyAtZyB3 d3ciCiBzdGFydF9jbWQ9IiUlUFJFRklYJSUvYmluL3RoaW4gJHtjb21tYW5kX2FyZ3N9IHN0 YXJ0IgogCiBydW5fcmNfY29tbWFuZCAiJDEiCg== --------------070102060205070203010508--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B9D45C4.3090608>