Date: Sat, 09 Jan 1999 23:51:00 -0800 From: Mike Smith <mike@smith.net.au> To: Poul-Henning Kamp <phk@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/conf options src/sys/sys sysctl.h src/sys/kern kern_sysctl.c src/sys/i386/conf LINT Message-ID: <199901100751.XAA04097@dingo.cdrom.com> In-Reply-To: Your message of "Sat, 09 Jan 1999 23:45:34 PST." <199901100745.XAA29001@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul, this sort of commit-war is reprehensible. Please don't stoop to childish measures like this to justify your personal bias. > phk 1999/01/09 23:45:33 PST > > Modified files: > sys/conf options > sys/sys sysctl.h > sys/kern kern_sysctl.c > sys/i386/conf LINT > Log: > Back out last change to sysctl. > > It was nay'ed before committing on the grounds that this is not > the way to do it, and has been decided as such several times in > the past. You were the only dissenting voice, with several consenting opinions against you. > There is not point in loading gobs of ascii into the kernel when > the only use of that ascii is presentation to the user. You're welcome to remove the rest of it then. You seem to be good at that. > The argument about KLD's is bogus, klds can store a file in > /usr/share/doc/sysctl/dev/foo/thisvar.txt with a description and > sysctl or other facilities can pick it up there. Actually, they can't. You're also breaking the association between the sysctl node and its documentation in an unmaintainable fashion. Please think carefully about the architectural consequences before making silly sugestions like this. > Proper documentation will take several K worth of text for many > sysctl variables, we don't want that in the kernel under any > circumstances. Correct; this belongs in the sysctl manpage for system-standard sysctls, and in the documentation shipped with a KLD for the KLD case. However the description field for sysctl nodes exists for a different reason, and if you are going to be pedantic, you must remove it from all instances of sysctl nodes in the kernel. > I will welcome any well thought out attempt at improving the > situation wrt. sysctl documentation, but this wasn't it. The attempt is actually well underway; it's unfortunate that you were able to sabotage this useful and well-reasoned attempt. I'm optomistic that you won't stumble across and subsequently exterminate the rest of it. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901100751.XAA04097>