Date: Tue, 4 Aug 2015 16:06:12 +0200 From: Edward Tomasz Napierala <trasz@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r286234 - head/sys/boot/common Message-ID: <20150804140612.GA13928@brick.home> In-Reply-To: <55BFAAEB.2020900@FreeBSD.org> References: <201508031627.t73GRbTB092225@repo.freebsd.org> <55BFAAEB.2020900@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 0803T2054, Andriy Gapon wrote: > On 03/08/2015 19:27, Edward Tomasz Napierala wrote: > > Author: trasz > > Date: Mon Aug 3 16:27:36 2015 > > New Revision: 286234 > > URL: https://svnweb.freebsd.org/changeset/base/286234 > > > > Log: > > Fix a problem which made loader(8) load non-kld files twice. > > What was the problem? > The change looks like defensive coding, but it's not clear why the loader would > attempt to load the same file more than once in the first place. It's because the "load_modules" Forth word gets called twice. It could be fixed, I guess, but I'm no good at Forth, so I chose the other way: I made the "load" command behave consistently; it already silently refused to load KLDs twice, and I made it behave the same way for other types of modules.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150804140612.GA13928>