Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Mar 2000 09:56:19 +0200
From:      Sheldon Hearn <sheldonh@uunet.co.za>
To:        Wolfram Schneider <wosch@panke.de.freebsd.org>
Cc:        Peter Wemm <peter@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/usr.sbin/adduser rmuser.perl 
Message-ID:  <76221.953884579@axl.ops.uunet.co.za>
In-Reply-To: Your message of "Thu, 23 Mar 2000 21:15:18 %2B0100." <20000323211518.A1245@paula.panke.de.freebsd.org> 

next in thread | previous in thread | raw e-mail | index | archive | help


On Thu, 23 Mar 2000 21:15:18 +0100, Wolfram Schneider wrote:

> >   MFC: fix a bad regexp that failed on valid names.
> 
> After this change you cannot delete the user `foo-bar' anymore.
> Also, \w is not the same as a-zA-Z0-9_ 
> \w may contain locale characters.

My bad.  I suggested the use of \w to Mark Newton, not realizing the
full implications you point out.

We probably want

	if ($login_name !~ /^[a-zA-Z0-9_][a-zA-Z0-9_-]*$/);

if we don't want usernames to start with '-', or

	if ($login_name !~ /^[a-zA-Z0-9_-]+$/);

if we don't care.

Ciao,
Sheldon.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?76221.953884579>