Date: Thu, 30 Dec 2010 13:38:01 +0300 From: Anonymous <swell.k@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/153541: [patch] devel/git: respect STRIP for stripping Message-ID: <86zkrnbl6e.fsf@gmail.com> Resent-Message-ID: <201012301040.oBUAe9xI022777@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 153541 >Category: ports >Synopsis: [patch] devel/git: respect STRIP for stripping >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Dec 30 10:40:09 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Anonymous >Release: FreeBSD 9.0-CURRENT amd64 >Organization: >Environment: cf. ports/150689 >Description: Strip binaries based on STRIP value, not only when WITH_DEBUG is used. It's as ports/146961 originally intended. depends on STRIP re-defined in bsd.port.pre.mk as per ports/153539 >How-To-Repeat: >Fix: --- a.diff begins here --- Index: devel/git/Makefile =================================================================== RCS file: /a/.cvsup/ports/devel/git/Makefile,v retrieving revision 1.96 diff -u -p -r1.96 Makefile --- devel/git/Makefile 19 Dec 2010 07:48:18 -0000 1.96 +++ devel/git/Makefile 30 Dec 2010 10:28:50 -0000 @@ -195,10 +195,6 @@ OPTIONS= GUI "Enable building of GUI too .include <bsd.port.options.mk> -.ifndef (WITH_DEBUG) -ALL_TARGET= all strip -.endif - .ifdef (WITH_P4) || defined (WITH_CONTRIB) USE_PYTHON= yes PLIST_SUB= PYTHON_VER=${PYTHON_VER} PYTHON="" @@ -314,6 +310,12 @@ PLIST_SUB+= ETCSHELLS="" PLIST_SUB+= ETCSHELLS="@comment " .endif +.include <bsd.port.pre.mk> + +.if defined(STRIP) && ${STRIP} != "" +ALL_TARGET= all strip +.endif + .if defined(MAINTAINER_MODE) DISTFILES+= ${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX}.sign \ ${PORTNAME}-manpages-${PORTVERSION}${EXTRACT_SUFX}.sign @@ -409,4 +411,4 @@ post-install: @${CAT} ${PKGMESSAGE} .endif -.include <bsd.port.mk> +.include <bsd.port.post.mk> --- a.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86zkrnbl6e.fsf>