Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Feb 2017 17:14:37 -0500
From:      Matteo Riondato <matteo@FreeBSD.org>
To:        Dimitry Andric <dim@FreeBSD.org>
Cc:        FreeBSD Current <freebsd-current@freebsd.org>
Subject:   Re: build with WITHOUT_GPL_DTC=y broken?
Message-ID:  <D5174BB9-977A-4105-9F1D-597FB9572D49@FreeBSD.org>
In-Reply-To: <71CFCEB9-6ED9-4278-A465-2BCB359A390A@FreeBSD.org>
References:  <065D64EE-D742-4E09-A3C0-658FE7020DC6@FreeBSD.org> <6515122C-B831-4EC5-9B59-F258C41E87A9@FreeBSD.org> <140BB2A6-31CD-4847-89B0-D83BB3B4CB27@FreeBSD.org> <71CFCEB9-6ED9-4278-A465-2BCB359A390A@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_C6D479AC-EA73-4B51-B865-37F9489F3D5B
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Feb 13, 2017, at 3:57 PM, Dimitry Andric <dim@FreeBSD.org> wrote:
>=20
> On 13 Feb 2017, at 20:27, Matteo Riondato <matteo@freebsd.org> wrote:
>>=20
>>> On Feb 13, 2017, at 1:58 PM, Dimitry Andric <dim@FreeBSD.org> wrote:
>>> On 13 Feb 2017, at 16:53, Matteo Riondato <matteo@freebsd.org> =
wrote:
>>>>=20
>>>> When I build world with WITHOUT_GPL_DTC=3Dy in src.conf (complete =
file after the error) I get the following error in stage 1.2: bootstrap =
tools. This is not a recent breakage, I=E2=80=99ve experienced it for a =
while.
>>>>=20
>>>> =3D=3D=3D> usr.bin/dtc (obj,all,install)
>>>> /usr/obj/usr/src/tmp/usr/src/usr.bin/dtc created for =
/usr/src/usr.bin/dtc
>>>> echo dtc: /usr/lib/libc.a =
/usr/obj/usr/src/tmp/legacy/usr/lib/libegacy.a >> .depend
>>>> echo dtc: /usr/lib/libc++.a >> .depend
>>>> c++  -O2 -pipe -DNDEBUG -MD -MF.depend.dtc.o -MTdtc.o =
-Qunused-arguments -I/usr/obj/usr/src/tmp/legacy/usr/include -std=3Dc++11 =
-fno-rtti -fno-exceptions  -Wno-c++11-extensions -c =
/usr/src/usr.bin/dtc/dtc.cc -o dtc.o
>>>> c++  -O2 -pipe -DNDEBUG -MD -MF.depend.input_buffer.o =
-MTinput_buffer.o -Qunused-arguments =
-I/usr/obj/usr/src/tmp/legacy/usr/include -std=3Dc++11 -fno-rtti =
-fno-exceptions  -Wno-c++11-extensions -c =
/usr/src/usr.bin/dtc/input_buffer.cc -o input_buffer.o
>>>> /usr/src/usr.bin/dtc/input_buffer.cc:547:53: error: type =
'dtc::(anonymous namespace)::expression' is not a direct or virtual base =
of 'binary_operator<Precedence, Op>'
>>>>     binary_operator(source_location l, const char *) : =
expression(l) {}
>>>>                                                        ^~~~~~~~~~
>>>=20
>>> Which FreeBSD version are you running on the host?  I've just tried
>>> building head/usr.bin/dtc on 12-CURRENT, 11-STABLE and 10-STABLE, =
but it
>>> all works just fine for me.
>>=20
>> Very interesting. I=E2=80=99m using 12.0-CURRENT #2 r313159.
>>=20
>> I even did two 'make cleandir' in /usr/src and removed /usr/obj/ , =
and still it does not compile.
>=20
> I see now, this is because you are using WITHOUT_ASSERT_DEBUG.  This
> adds -DNDEBUG to CFLAGS, and apparently you are the first person to =
hit
> this NDEBUG-only code. :)
>=20
> I committed a fix in r313709.

Thank you!

Matteo


--Apple-Mail=_C6D479AC-EA73-4B51-B865-37F9489F3D5B
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJYoi/NAAoJEJ/Xw+PLA1GfEOwP/R/RFT9S0n8amV6dRWttK5vW
UH+DZMYEXhd9nX+9Oe/uZn0IFdg26idfhCKcMUM4qRe6vjb0/tPnyFCHcoKbF0NY
jcUx/XhJBA3t8rHuu61bJvS7Z30qdOtF0sJcc2KcEOsSufgV5a6assYGS64s6fJg
HWqjJlE677Ua1M9BRW6809xIZgIiTA6PTUnEY897YcsBcBaptXSFhLkaLPU+LM+/
TSONDesSe6VabIh+EnSuX2eiaeBbhD87EYKeyxR8GiyEal0fXn21Yh2sP4gWOR1w
cALefFPGkM+78SfsURFv3xW4UK5Wi+76L1fUNa95ynDTd9xRZbL2yeO9GbEsFc4Z
Uj+AqEBpzYVeEMAxKxJDe2uuG/ttFEIHSuRJ7058+DJSPDBELv8HNoG10XjFtV2U
uhC3YyEjq40gFKhZBSUfL4ZZSY9W1PYrgDoPmkNaI4tpv+G7ExARYcvJDeZ7bVwz
0633ENmJe18foMU58KiHFNEf1ndomg4S92dLfdQ1uI+IvvkEA5BpHUREj41CAgom
qAiS7s7B71T0lLMeMp0QI5D9UpIjRYVi+enX5v/BVCjkjFV/C+l31mEpSCJfvI1t
idTAp4d9E14y15od3RxoNiTAnMGjIzqAreeOz6oQz6oSG3EjwcZYNWObNXBbN4C2
2xG8ZINhP1N7XRoOf2oq
=Q8E+
-----END PGP SIGNATURE-----

--Apple-Mail=_C6D479AC-EA73-4B51-B865-37F9489F3D5B--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D5174BB9-977A-4105-9F1D-597FB9572D49>