Date: Sat, 26 Feb 2005 19:00:53 GMT From: Gavin Atkinson <gavin.atkinson@ury.york.ac.uk> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/78125: Remove unused code from idmapd.c Message-ID: <200502261900.j1QJ0rd0065644@buffy.york.ac.uk> Resent-Message-ID: <200502261910.j1QJALCa072559@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 78125 >Category: bin >Synopsis: Remove unused code from idmapd.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Feb 26 19:10:21 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Gavin Atkinson >Release: FreeBSD 5.3-STABLE i386 >Organization: >Environment: System: FreeBSD buffy.york.ac.uk 5.3-STABLE FreeBSD 5.3-STABLE #0: Sat Feb 12 20:42:16 GMT 2005 root@buffy.york.ac.uk:/usr/obj/usr/src/sys/BUFFY i386 >Description: In src/sbin/idmapd/idmapd.c, there's some error-checking code which can never evaluate to true, and indeed seems to be left over from previous code (judging by the error message). >How-To-Repeat: n/a >Fix: --- idmapd.patch begins here --- Index: src/sbin/idmapd/idmapd.c =================================================================== RCS file: /usr/cvs/src/sbin/idmapd/idmapd.c,v retrieving revision 1.5 diff -u -r1.5 idmapd.c --- src/sbin/idmapd/idmapd.c 15 Apr 2004 16:12:12 -0000 1.5 +++ src/sbin/idmapd/idmapd.c 26 Feb 2005 16:27:41 -0000 @@ -339,12 +339,6 @@ TAILQ_INIT(&upcall_q); - if (error) { - perror("sigaction"); - exit(1); - } - - fd = open(DEV_PATH, O_RDWR, S_IRUSR | S_IWUSR); if (fd < 0) { --- idmapd.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200502261900.j1QJ0rd0065644>