Date: Fri, 21 Nov 2008 17:00:10 -0500 From: John Baldwin <jhb@freebsd.org> To: David Xu <davidxu@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys aio.h signal.h signalvar.h src/sys/kern syscalls.master vfs_aio.c Message-ID: <200811211700.11204.jhb@freebsd.org> In-Reply-To: <200510300212.j9U2CnWl089007@repoman.freebsd.org> References: <200510300212.j9U2CnWl089007@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 29 October 2005 10:12:49 pm David Xu wrote: > davidxu 2005-10-30 02:12:49 UTC > > FreeBSD src repository > > Modified files: > sys/sys signal.h signalvar.h aio.h > sys/kern syscalls.master vfs_aio.c > Log: > Fix sigevent's POSIX incompatible problem by adding member fields > sigev_notify_function and sigev_notify_attributes. AIO syscalls > use sigevent, so they have to be adjusted. > > Reviewed by: alc I'm looking at doing 32-bit compat for AIO, and the __spare__ thing in 'struct aiocb' strikes me as rather odd. For one, why not use 'struct osigevent __spare__;' instead of the explicit sizeof()'s? The sizeof's make assumptions about padding for example. Secondly, since you bumped the syscalls for the new structure, you didn't need the __spare__ hack at all. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200811211700.11204.jhb>