Date: Mon, 03 Jun 2013 13:12:37 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Tom Rhodes <trhodes@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r319792 - head/sysutils/fsc Message-ID: <51ACDC95.4060600@FreeBSD.org> In-Reply-To: <20130603133012.114c2ae7.trhodes@FreeBSD.org> References: <201306031632.r53GWPdP069628@svn.freebsd.org> <51ACC994.4060608@FreeBSD.org> <20130603133012.114c2ae7.trhodes@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2RETHHRAOUNNQXJSKQPLB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 6/3/2013 12:30 PM, Tom Rhodes wrote: > On Mon, 03 Jun 2013 11:51:32 -0500 > Bryan Drewery <bdrewery@FreeBSD.org> wrote: >=20 >> This is bad form. If you are changing upstream code it should be a new= >> release version, not a reroll. We frequently have problems with other >> upstreams doing this and should follow our own guidelines. >=20 > I'm not bumping the version used for a simple gcc->clang warning > fix. That's why I just bumped PORTVERSION. If we want to do a > new version, I'll get ahold of the NetBSD people, who also work > with keeping a port, and discuss doing that. In this case, it > was a simple fix rather than adding a 2 line patch to a files/ > directory. >=20 The proper way to do is this a new release, or a patch in files with a PORTREVISION, or a sed in post-patch. This is the convention. Rerolling upstream is a big no no. Rerolling is obscure and very frowned upon. This also impacts NetBSD if they are tracking checksums, and any other projects depending on the checksum of the upstream tarball. If you had a ports committer approve/review this change, which you should have and should do in the future, this would have been avoided. >=20 >> >> On 6/3/2013 11:32 AM, Tom Rhodes wrote: >>> Author: trhodes (src,doc committer) >>> Date: Mon Jun 3 16:32:24 2013 >>> New Revision: 319792 >>> URL: http://svnweb.freebsd.org/changeset/ports/319792 >>> >>> Log: >>> Update to fix breakage with clang. >>> =20 >>> PR: 179050 >>> Requested by: many >>> >>> Modified: >>> head/sysutils/fsc/Makefile >>> head/sysutils/fsc/distinfo >>> >>> Modified: head/sysutils/fsc/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/sysutils/fsc/Makefile Mon Jun 3 16:02:16 2013 (r319791) >>> +++ head/sysutils/fsc/Makefile Mon Jun 3 16:32:24 2013 (r319792) >>> @@ -8,7 +8,7 @@ >>> =20 >>> PORTNAME=3D fsc >>> PORTVERSION=3D 1.0.1 >>> -PORTREVISION=3D 1 >>> +PORTREVISION=3D 2 >>> CATEGORIES=3D sysutils >>> MASTER_SITES=3D LOCAL >>> MASTER_SITE_SUBDIR=3D trhodes >>> >>> Modified: head/sysutils/fsc/distinfo >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- head/sysutils/fsc/distinfo Mon Jun 3 16:02:16 2013 (r319791) >>> +++ head/sysutils/fsc/distinfo Mon Jun 3 16:32:24 2013 (r319792) >>> @@ -1,2 +1,2 @@ >>> -SHA256 (fsc-1.0.1.tar.gz) =3D 3cae8021534dfc7074173ceca0ffd1483c2f58= badb28663d6a99bcbf754e1f0a >>> -SIZE (fsc-1.0.1.tar.gz) =3D 11708 >>> +SHA256 (fsc-1.0.1.tar.gz) =3D 41979af3f5ed2fd37e30839cacc22408ac65f2= fd20df30de1e5114bc0d2e733b >>> +SIZE (fsc-1.0.1.tar.gz) =3D 12435 >>> >> >> >> --=20 >> Regards, >> Bryan Drewery >> >> --=20 Regards, Bryan Drewery ------enig2RETHHRAOUNNQXJSKQPLB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJRrNyYAAoJEG54KsA8mwz5ubcP+wV8eJLbZRhMggqAahJzUG2Y OTMvqBOuu32U0TpDEpS15+pRrCINTNuoKSgBY/ljhJpFyS9f6fYE5xTCAWIEXWCP EPz07XGKWEgJGu9jOtUBDueaNIKspdKuyYnA2gFA5wDiMd0TL6TbomaOQB3MHw/S RLoe5ZDJzPi/gL5nWu+PTJjAhi8kWNtrAIpoJSY8HEVH7tn/Q1yKMHie8r17MRFR xE5qnih6GFKqZTnkN1IpR9YdMWK9UvXxXUZ6GC/sbs2DmR3cv0g2lVNsEHGeiqf6 dg61qlcjAmxm0ulUQzrmf7HnpSKxVDBL2tSxwZakoOZ8I4g5yAIjekadpvtNSJ8r kTuFaoYpsS4t9nHKhaoVCZomGT55hntWoxBgqwjHS7aP9I0Bni7YFEJ73/AAMWvD wSZcwjjUBepgDem493ERMvScgMwh7/DN8m8ZxlwGQc50WheVE15UT3gPYcc9XH7M VrXOVq6CNIwE5fGTktHPrTjyShTn+PBsv0nj0YCJeHXAj/b4MvWbeBQdl3ipnFG3 A4IOw+5WeEYv6EKOgPGXOhULn4erINeynxW9SGIqy2Iin/rqYGtQTRRLD/DDFX5k 8+bf/IraA12HsvYmbSTfIal9RNevDnefIxDuPwvOksp/yTIEVgTZHsE5319JHVUS tXr2rdyL+iLY3phrSrbH =GGri -----END PGP SIGNATURE----- ------enig2RETHHRAOUNNQXJSKQPLB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51ACDC95.4060600>