Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Jul 2005 19:30:56 -0700 (PDT)
From:      Jeff Roberson <jroberson@chesapeake.net>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/alpha/include atomic.h src/sys/amd64/include atomic.h src/sys/arm/include atomic.h src/sys/dev/hatm         if_hatm_intr.c src/sys/dev/hwpmc hwpmc_mod.c src/sys/i386/include         atomic.h src/sys/ia64/include atomic.h src/sys/kern kern_mutex.c ...
Message-ID:  <20050719192959.C592@10.0.0.1>
In-Reply-To: <200507151817.j6FIHx9A019286@repoman.freebsd.org>
References:  <200507151817.j6FIHx9A019286@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 15 Jul 2005, John Baldwin wrote:

> jhb         2005-07-15 18:17:59 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/alpha/include    atomic.h
>    sys/amd64/include    atomic.h
>    sys/arm/include      atomic.h
>    sys/dev/hatm         if_hatm_intr.c
>    sys/dev/hwpmc        hwpmc_mod.c
>    sys/i386/include     atomic.h
>    sys/ia64/include     atomic.h
>    sys/kern             kern_mutex.c
>    sys/powerpc/include  atomic.h
>    sys/sparc64/include  atomic.h
>    sys/sys              mutex.h
>  Log:
>  Convert the atomic_ptr() operations over to operating on uintptr_t
>  variables rather than void * variables.  This makes it easier and simpler
>  to get asm constraints and volatile keywords correct.

This breaks ULE as I use atomic cmpsets while passing in actual pointers. 
Do I have to cast everywhere now?  This kind of breaks the notion of it 
operating on a pointer.  Could we at least have an inline or define that 
does the type conversion?

>
>  MFC after:      3 days
>  Tested on:      i386, alpha, sparc64
>  Compiled on:    ia64, powerpc, amd64
>  Kernel toolchain busted on:     arm
>
>  Revision  Changes    Path
>  1.22      +18 -61    src/sys/alpha/include/atomic.h
>  1.35      +18 -52    src/sys/amd64/include/atomic.h
>  1.9       +4 -8      src/sys/arm/include/atomic.h
>  1.19      +6 -3      src/sys/dev/hatm/if_hatm_intr.c
>  1.11      +2 -1      src/sys/dev/hwpmc/hwpmc_mod.c
>  1.39      +18 -52    src/sys/i386/include/atomic.h
>  1.9       +19 -58    src/sys/ia64/include/atomic.h
>  1.155     +9 -10     src/sys/kern/kern_mutex.c
>  1.12      +20 -63    src/sys/powerpc/include/atomic.h
>  1.9       +1 -1      src/sys/sparc64/include/atomic.h
>  1.80      +14 -12    src/sys/sys/mutex.h
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050719192959.C592>