Date: Thu, 27 Nov 2008 00:06:21 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: kabaev@gmail.com Cc: jfv@FreeBSD.org, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r185356 - head/sys/dev/ixgbe Message-ID: <20081127.000621.1413927847.imp@bsdimp.com> In-Reply-To: <20081126213204.14db9a63@kan.dnsalias.net> References: <200811270219.mAR2Ji2M073024@svn.freebsd.org> <20081126213204.14db9a63@kan.dnsalias.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20081126213204.14db9a63@kan.dnsalias.net>
Alexander Kabaev <kabaev@gmail.com> writes:
: On Thu, 27 Nov 2008 02:19:44 +0000 (UTC)
: Jack F Vogel <jfv@FreeBSD.org> wrote:
:
: > Author: jfv
: > Date: Thu Nov 27 02:19:44 2008
: > New Revision: 185356
: > URL: http://svn.freebsd.org/changeset/base/185356
: >
: > Log:
: > Small nit I just noticed, a pre-decrement should be post.
: >
: > Modified:
: > head/sys/dev/ixgbe/ixgbe.c
: >
: > Modified: head/sys/dev/ixgbe/ixgbe.c
: > ==============================================================================
: > --- head/sys/dev/ixgbe/ixgbe.c Thu Nov 27 02:18:43 2008
: > (r185355) +++ head/sys/dev/ixgbe/ixgbe.c Thu Nov 27 02:19:44
: > 2008 (r185356) @@ -3244,7 +3244,7 @@ fail:
: > * the rings that completed, the failing case will have
: > * cleaned up for itself. 'j' failed, so its the terminus.
: > */
: > - for (int i = 0; i < j; ++i) {
: > + for (int i = 0; i < j; i++) {
: > rxr = &adapter->rx_rings[i];
: > for (int n = 0; n < adapter->num_rx_desc; n++) {
: > struct ixgbe_rx_buf *rxbuf;
:
: Is C99 construct here intentional? If so, when did we agree on using
: only C99 compilers on our code base?
I'm not sure about *THIS* c99 construct, but we've been heavily
relying on the field name initializer stuff for a couple of years now.
eg:
static struct cdevsw lpt_cdevsw = {
.d_version = D_VERSION,
.d_flags = D_NEEDGIANT,
.d_open = lptopen,
.d_close = lptclose,
.d_read = lptread,
.d_write = lptwrite,
.d_ioctl = lptioctl,
.d_name = LPT_NAME,
};
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081127.000621.1413927847.imp>