Date: Mon, 17 Oct 2011 14:23:48 +0100 From: Steven Chamberlain <steven@pyro.eu.org> To: Adrian Chadd <adrian@freebsd.org> Cc: freebsd-net@freebsd.org Subject: Re: kern/149643: [rum] device not sending proper beacon frames in ap mode Message-ID: <4E9C2C64.5030007@pyro.eu.org> In-Reply-To: <CAJ-Vmo=AeibaUybmY3L=Ugaxm2qZyQT%2B0Sh5=qN=_oOkqewdEg@mail.gmail.com> References: <201110152200.p9FM0QUO044812@freefall.freebsd.org> <CAJ-VmomdNhZd7fEv9CHTBrMaQabO1Xks4Y-gjTMKEe3KNSNPAQ@mail.gmail.com> <4E9A5FB6.7040904@pyro.eu.org> <4E9B062A.9050408@pyro.eu.org> <CAJ-Vmonvs=HaoAGvpLw43S4ATmZUi2vaG8JYFhRZAZhfvwcWbQ@mail.gmail.com> <4E9B315A.6030607@pyro.eu.org> <CAJ-Vmo=AeibaUybmY3L=Ugaxm2qZyQT%2B0Sh5=qN=_oOkqewdEg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17/10/11 14:13, Adrian Chadd wrote: > I've committed this to -HEAD in r226465. > I'll MFC this to -9 and -8 in the next 3 or so days, re@ approval pending. Argh... there were a couple of issues someone pointed out to me off-list that you may not have seen: On 17/10/11 01:16, Gang 'Henry' Hu wrote: > There are some minor problems: > > + error = rum_do_request(sc, &req, buf + offset); > > At this line, you should cast buf to (char*), since buf is (void*) > which cannot be used in calculation... > > And you should also return 0 at the end of the function, else there > would be no return value.... I was going to get back to you with a slightly revised freebsd patch to fix those before you committed. Otherwise, Henry said it has fixed the problem for him (in 8.2-STABLE). Regards, -- Steven Chamberlain steven@pyro.eu.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E9C2C64.5030007>