Date: Wed, 31 Oct 2001 20:57:43 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/natd natd.8 natd.c Message-ID: <20011031205743.L91951@sunbay.com> In-Reply-To: <73893.1004553742@critter.freebsd.dk>; from phk@critter.freebsd.dk on Wed, Oct 31, 2001 at 07:42:22PM %2B0100 References: <20011031202106.G91951@sunbay.com> <73893.1004553742@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 31, 2001 at 07:42:22PM +0100, Poul-Henning Kamp wrote: > In message <20011031202106.G91951@sunbay.com>, Ruslan Ermilov writes: > > > >Please back this change out, indicated by: ``Requested by: ru''. > > No. > You can't just say "no" here, as "every disputed change should be backed out if requested by a maintainer", but see below. > >I don't agree with this change; > > Well, I agree with this change. > > >this is not what Flemming submitted. > > No, I changed it with Flemmings permission. > I wasn't aware, and you didn't mention it in the commitlog. > >His patch added the -nolog_ipfw_denied, while you changed this to > >-log_ipfw_denied, breaking POLA (the current behavior of natd), > >which is BAD, as this message (usually) indicates a misconfigured > >firewall. > > No, Adding negative options breaks POLA. > No, changing the current behavior breaks POLA. > >As the maintainer of natd(8), I would appreciate it if you mailed > >me about your intentions to commit this. > > Your totally unflexible behaviour in the discussion with Flemming > (and me) about this change earns you no credit as maintainer. > Unflexible? We were disputing the change, I offered an alternate solution which was rejected, then I swamped with some non-FreeBSD related things, and you just committed this without even telling me about your intentions. I'm sure you won't behav like this if Flemming wasn't Dutch. > >I re-opened the PR in question, and will look into this soon after > >I return from BSDCon/Euro. > > Lets discuss it at BSDcon/Euro then and leave the tree in peace > until then. > Please make this option the default then, and let's discuss it at the Con. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011031205743.L91951>