Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Jun 2019 10:44:51 -0700
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        Warner Losh <imp@bsdimp.com>
Cc:        Cy Schubert <Cy.Schubert@cschubert.com>, FreeBSD Current <freebsd-current@freebsd.org>, "Bjoern A. Zeeb" <bz@freebsd.org>, "Julian H. Stacey" <jhs@berklix.com>, current@freebsd.org
Subject:   Re: sys/modules/sdio broken in .svn_revision 348842  'opt_cam.h' not found
Message-ID:  <201906171744.x5HHipEx008274@slippy.cwsent.com>
In-Reply-To: Message from Warner Losh <imp@bsdimp.com> of "Mon, 17 Jun 2019 10:13:54 -0700." <CANCZdfp_Ez8tOsy8C=qi3dgxnTyF0uc3AQjz4ksz1s_Sjr06%2BQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <CANCZdfp_Ez8tOsy8C=qi3dgxnTyF0uc3AQjz4ksz1s_Sjr06+Q@mail.gma
il.com>
, Warner Losh writes:
> --000000000000c175e9058b881f98
> Content-Type: text/plain; charset="UTF-8"
>
> On Mon, Jun 17, 2019, 8:06 AM Cy Schubert <Cy.Schubert@cschubert.com> wrote:
>
> > On June 17, 2019 3:55:45 AM PDT, "Bjoern A. Zeeb" <bz@FreeBSD.org> wrote:
> > >On 17 Jun 2019, at 10:37, Mark Linimon wrote:
> > >
> > >> On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey wrote:
> > >>> svn_revision 348842
> > >> [ ...]
> > >>> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal error:
> > >>>       'opt_cam.h' file not found
> > >>> #include "opt_cam.h"
> > >>>          ^~~~~~~~~~~
> > >>> 1 error generated.
> > >>
> > >> This is extremely unlikely to be r348842.  I would investigate
> > >r349025
> > >> instead.  (Committer Cc:ed.)
> > >
> > >Almost, more likely me.  I just had a look.  I am not exactly sure how
> > >to reproduce this?
> > >
> > >/bz
> > >_______________________________________________
> > >freebsd-current@freebsd.org mailing list
> > >https://lists.freebsd.org/mailman/listinfo/freebsd-current
> > >To unsubscribe, send any mail to
> > >"freebsd-current-unsubscribe@freebsd.org"
> >
> > Could this be a possible race? I had an unrelated build failure on one of
> > my machines, all with the same src tree. Simply restarting the failed
> > buildworld resolved it. All my other machines had no such failure.
> >
>
> The thing I fixed wasn't a race per se, but just s missing dependency for
> the stand alone build case. I fixed exactly the bug reported, and the
> report came from a rev w/o my change. I think it is just that simple.
>
> Warner

I doubt your change had anything to do with the 1/4 builds of mine that 
failed. Lesson learned: time to slow down a little and at least save 
the output for possible subsequent discussion. And, slow down before 
hitting reply. This is becoming a pattern this week. Sorry for the SPAM.


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201906171744.x5HHipEx008274>