Date: Mon, 20 Sep 2010 22:30:06 GMT From: pluknet <pluknet@gmail.com> To: freebsd-bugs@FreeBSD.org Subject: Re: misc/146119: [tools] [patch] (attempt to) cleanup tools/tools/umastat Message-ID: <201009202230.o8KMU6dO020411@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR misc/146119; it has been noted by GNATS. From: pluknet <pluknet@gmail.com> To: bug-followup@FreeBSD.org, pluknet@gmail.com Cc: Subject: Re: misc/146119: [tools] [patch] (attempt to) cleanup tools/tools/umastat Date: Tue, 21 Sep 2010 02:22:08 +0400 --001636e8ff45d666230490b8570d Content-Type: text/plain; charset=ISO-8859-1 Ok, after some related activity in head, I picked up this PR from my attic, and couldn't recall the way to reproduce the kvm_open() issue in ten minutes. Here are the instructions: 1) before: # ./umastat -M /dev/mem > /dev/null umastat: kvm_nlist: No such file or directory umastat: kvm_nlist: No such file or directory umastat: kvm_nlist: No such file or directory umastat: kvm_nlist: No such file or directory 2) after: # ./umastat -M /dev/mem > /dev/null # Somehow I managed to botch the original patch in PR to non-working state before submitting. The corrected version attached. -- wbr, pluknet --001636e8ff45d666230490b8570d Content-Type: text/plain; charset=US-ASCII; name="umastat.txt" Content-Disposition: attachment; filename="umastat.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gebwhjwl0 SW5kZXg6IHRvb2xzL3Rvb2xzL3VtYXN0YXQvdW1hc3RhdC5jCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHRvb2xz L3Rvb2xzL3VtYXN0YXQvdW1hc3RhdC5jCShyZXZpc2lvbiAyMDk5ODgpCisrKyB0b29scy90b29s cy91bWFzdGF0L3VtYXN0YXQuYwkod29ya2luZyBjb3B5KQpAQCAtMzcsNiArMzcsNyBAQAogCiAj aW5jbHVkZSA8ZXJyLmg+CiAjaW5jbHVkZSA8a3ZtLmg+CisjaW5jbHVkZSA8bGltaXRzLmg+CiAj aW5jbHVkZSA8bWVtc3RhdC5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8c3RkbGli Lmg+CkBAIC0xOTYsNyArMTk3LDcgQEAKIExJU1RfSEVBRChidWNrZXRsaXN0LCB1bWFfYnVja2V0 KTsKIAogc3RhdGljIHZvaWQKLXVtYV9wcmludF9idWNrZXQoc3RydWN0IHVtYV9idWNrZXQgKnVi cCwgY29uc3QgY2hhciAqc3BhY2VzKQordW1hX3ByaW50X2J1Y2tldChzdHJ1Y3QgdW1hX2J1Y2tl dCAqdWJwLCBjb25zdCBjaGFyICpzcGFjZXMgX191bnVzZWQpCiB7CiAKIAlwcmludGYoInsgdWJf Y250ID0gJWQsIHViX2VudHJpZXMgPSAlZCB9IiwgdWJwLT51Yl9jbnQsCkBAIC0yMzAsNyArMjMx LDcgQEAKIAl9CiAKIAlwcmludGYoIlxuIik7Ci0JcHJpbnRmKCIlc307ICAvLyB0b3RhbCBjbnQg JWxsdSwgdG90YWwgZW50cmllcyAlbGx1XG4iLCBzcGFjZXMsCisJcHJpbnRmKCIlc307ICAvLyB0 b3RhbCBjbnQgJWp1LCB0b3RhbCBlbnRyaWVzICVqdVxuIiwgc3BhY2VzLAogCSAgICB0b3RhbF9j bnQsIHRvdGFsX2VudHJpZXMpOwogfQogCkBAIC0yNDIsOCArMjQzLDggQEAKIAlpbnQgcmV0Owog CiAJcHJpbnRmKCIlcyVzWyVkXSA9IHtcbiIsIHNwYWNlcywgbmFtZSwgY3B1KTsKLQlwcmludGYo IiVzICB1Y19mcmVlcyA9ICVsbHU7XG4iLCBzcGFjZXMsIGNhY2hlLT51Y19mcmVlcyk7Ci0JcHJp bnRmKCIlcyAgdWNfYWxsb2NzID0gJWxsdTtcbiIsIHNwYWNlcywgY2FjaGUtPnVjX2FsbG9jcyk7 CisJcHJpbnRmKCIlcyAgdWNfZnJlZXMgPSAlanU7XG4iLCBzcGFjZXMsIGNhY2hlLT51Y19mcmVl cyk7CisJcHJpbnRmKCIlcyAgdWNfYWxsb2NzID0gJWp1O1xuIiwgc3BhY2VzLCBjYWNoZS0+dWNf YWxsb2NzKTsKIAogCWlmIChjYWNoZS0+dWNfZnJlZWJ1Y2tldCAhPSBOVUxMKSB7CiAJCXJldCA9 IGtyZWFkKGt2bSwgY2FjaGUtPnVjX2ZyZWVidWNrZXQsICZ1Yiwgc2l6ZW9mKHViKSwgMCk7CkBA IC0yODYsNiArMjg3LDcgQEAKIAlzaXplX3QgdXpwX3VzZXJzcGFjZV9sZW47CiAJY2hhciAqbWVt ZiwgKm5saXN0ZjsKIAlpbnQgY2g7CisJY2hhciBlcnJidWZbX1BPU0lYMl9MSU5FX01BWF07CiAK IAltZW1mID0gbmxpc3RmID0gTlVMTDsKIAl3aGlsZSAoKGNoID0gZ2V0b3B0KGFyZ2MsIGFyZ3Ys ICJNOk46IikpICE9IC0xKSB7CkBAIC0zMDgsOSArMzEwLDkgQEAKIAlpZiAobmxpc3RmICE9IE5V TEwgJiYgbWVtZiA9PSBOVUxMKQogCQl1c2FnZSgpOwogCi0Ja3ZtID0ga3ZtX29wZW4obmxpc3Rm LCBtZW1mLCBOVUxMLCAwLCAidW1hc3RhdCIpOworCWt2bSA9IGt2bV9vcGVuZmlsZXMobmxpc3Rm LCBtZW1mLCBOVUxMLCAwLCBlcnJidWYpOwogCWlmIChrdm0gPT0gTlVMTCkKLQkJZXJyKC0xLCAi a3ZtX29wZW4iKTsKKwkJZXJyeCgtMSwgImt2bV9vcGVuZmlsZXM6ICVzIiwgZXJyYnVmKTsKIAog CWlmIChrdm1fbmxpc3Qoa3ZtLCBuYW1lbGlzdCkgIT0gMCkKIAkJZXJyKC0xLCAia3ZtX25saXN0 Iik7CkBAIC00MTIsMjAgKzQxNCwyMCBAQAogCQkJfQogCQkJcHJpbnRmKCIgIFpvbmUge1xuIik7 CiAJCQlwcmludGYoIiAgICB1el9uYW1lID0gXCIlc1wiO1xuIiwgbmFtZSk7Ci0JCQlwcmludGYo IiAgICB1el9hbGxvY3MgPSAlbGx1O1xuIiwKKwkJCXByaW50ZigiICAgIHV6X2FsbG9jcyA9ICVq dTtcbiIsCiAJCQkgICAgdXpwX3VzZXJzcGFjZS0+dXpfYWxsb2NzKTsKLQkJCXByaW50ZigiICAg IHV6X2ZyZWVzID0gJWxsdTtcbiIsCisJCQlwcmludGYoIiAgICB1el9mcmVlcyA9ICVqdTtcbiIs CiAJCQkgICAgdXpwX3VzZXJzcGFjZS0+dXpfZnJlZXMpOwotCQkJcHJpbnRmKCIgICAgdXpfZmFp bHMgPSAlbGx1O1xuIiwKKwkJCXByaW50ZigiICAgIHV6X2ZhaWxzID0gJWp1O1xuIiwKIAkJCSAg ICB1enBfdXNlcnNwYWNlLT51el9mYWlscyk7CiAJCQlwcmludGYoIiAgICB1el9maWxscyA9ICV1 O1xuIiwKIAkJCSAgICB1enBfdXNlcnNwYWNlLT51el9maWxscyk7CiAJCQlwcmludGYoIiAgICB1 el9jb3VudCA9ICV1O1xuIiwKIAkJCSAgICB1enBfdXNlcnNwYWNlLT51el9jb3VudCk7Ci0JCQl1 bWFfcHJpbnRfYnVja2V0bGlzdChrdm0sIChzdHJ1Y3QgYnVja2V0bGlzdCAqKQorCQkJdW1hX3By aW50X2J1Y2tldGxpc3Qoa3ZtLCAodm9pZCAqKQogCQkJICAgICZ1enBfdXNlcnNwYWNlLT51el9m dWxsX2J1Y2tldCwgInV6X2Z1bGxfYnVja2V0IiwKIAkJCSAgICAiICAgICIpOwotCQkJdW1hX3By aW50X2J1Y2tldGxpc3Qoa3ZtLCAoc3RydWN0IGJ1Y2tldGxpc3QgKikKKwkJCXVtYV9wcmludF9i dWNrZXRsaXN0KGt2bSwgKHZvaWQgKikKIAkJCSAgICAmdXpwX3VzZXJzcGFjZS0+dXpfZnJlZV9i dWNrZXQsICJ1el9mcmVlX2J1Y2tldCIsCiAJCQkgICAgIiAgICAiKTsKIAo= --001636e8ff45d666230490b8570d--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009202230.o8KMU6dO020411>