Date: Mon, 4 Aug 1997 03:01:09 -0500 (EST) From: "John S. Dyson" <toor@dyson.iquest.net> To: phk@dk.tfs.com (Poul-Henning Kamp) Cc: dg@root.com, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c Message-ID: <199708040801.DAA00278@dyson.iquest.net> In-Reply-To: <14326.870681111@critter.dk.tfs.com> from Poul-Henning Kamp at "Aug 4, 97 09:51:51 am"
next in thread | previous in thread | raw e-mail | index | archive | help
> In message <199708040741.AAA08057@implode.root.com>, David Greenman writes: > >>phk 1997/08/04 00:30:45 PDT > >> > >> Modified files: > >> sys/ufs/ffs ffs_alloc.c > >> Log: > >> We got a couple of "map mismatch" panics from the following > >> code. According to the crash dump, bpref is set to 445 > >> and cgp->cg_nclusterblks is 444. Hence in the for loop, > >> the test fails immediately but the following failure check > >> (got == cgp->cg_nclusterblks) doesn't trigger because got > > >> cgp->cg_nclusterblks. This wreaks havoc in the code after that. > >> > >> Fix: Move one source bit to the left :-) > >> > >> Noticed by: Mike Hibler <mike@fast.cs.utah.edu> > >> Submitted by: Kirk McKusick <mckusick@McKusick.COM> > > > > Just so people aren't confused: the above patch has no affect on FreeBSD; > >it's in an area of code that isn't even compiled. > > > >-DG > > > >David Greenman > >Core-team/Principal Architect, The FreeBSD Project > > True, should have said that. This commit is just to keep us in sync > with Kirk. > I hope to re-enable the code (in our framework) someday. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199708040801.DAA00278>