Date: Sat, 11 Mar 2017 13:09:47 -0500 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Ian Lepore <ian@freebsd.org> Cc: freebsd-arm@freebsd.org Subject: Re: Odd-looking serial console prompt on RPI2 Message-ID: <20170311180947.ro5obisuaemvudkp@mutt-hbsd> In-Reply-To: <1489255444.40576.57.camel@freebsd.org> References: <20170302000334.GA99403@www.zefox.net> <1488419304.60166.26.camel@freebsd.org> <20170302020116.GA98466@bluezbox.com> <1488420309.60166.32.camel@freebsd.org> <CA%2B7sy7Bv=-2mx2MJP18ZnbNp2yO2hKukw=KALn711txaxsk=rg@mail.gmail.com> <1488664965.69705.24.camel@freebsd.org> <20170307190937.r7n45xj67tnhevv4@mutt-hbsd> <20170307192918.2garie2ow6lzekg7@mutt-hbsd> <20170311174940.bze4k7ndjdemmu4l@mutt-hbsd> <1489255444.40576.57.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--wrrrn5gptp5ytu4l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 11, 2017 at 11:04:04AM -0700, Ian Lepore wrote: > On Sat, 2017-03-11 at 12:49 -0500, Shawn Webb wrote: > > On Tue, Mar 07, 2017 at 02:29:18PM -0500, Shawn Webb wrote: > > >=20 > > > On Tue, Mar 07, 2017 at 02:09:37PM -0500, Shawn Webb wrote: > > > >=20 > > > > On Sat, Mar 04, 2017 at 03:02:45PM -0700, Ian Lepore wrote: > > > > >=20 > > > > > The bugs should be fixed as of r314682. ?It looks like the bugs > > > > > have > > > > > long been in the pl011 driver, but were masked by having a fifo > > > > > depth > > > > > of 1 byte -- it all sorta worked by accident previously. > > > > Thanks for the fix! But it looks to be only partial. When I > > > > connect to > > > > the serial console via either cu or screen, I don't get corrupted > > > > text, > > > > but no keypresses are registered. Hitting enter at the login > > > > prompt does > > > > absolutely nothing. I'm at the latest commit of > > > > hardened/current/master > > > > on HardenedBSD for both the RPI3 and my laptop. > > > >=20 > > > > I'm using this serial cable from Adafruit: > > > > https://www.adafruit.com/product/954 > > > It looks like I had a bad cable. Sorry for the line noise. > > > Switching to > > > a different cable worked. > > Looks like the problem is back, but manifest in a different way. > > Screenshot: > >=20 > > https://goo.gl/photos/XYx6v1jCTVCGrnhd6 > >=20 > > Thanks, > >=20 >=20 > I wonder if rpi3 needs the same smaller-fifo fix as a 32-bit rpi. ?Just > to test that theory, can you see if the attached patch fixes problem? > ?If it does, I'll figure out how to detect rpi3 at runtime and set the > sizes properly. >=20 > -- Ian > Index: sys/dev/uart/uart_dev_pl011.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/dev/uart/uart_dev_pl011.c (revision 314917) > +++ sys/dev/uart/uart_dev_pl011.c (working copy) > @@ -464,7 +464,7 @@ uart_pl011_bus_probe(struct uart_softc *sc) > is_bcm2835 =3D ofw_bus_is_compatible(sc->sc_dev, "brcm,bcm2835-pl011") = || > ofw_bus_is_compatible(sc->sc_dev, "broadcom,bcm2835-uart"); > #else > - is_bcm2835 =3D false; > + is_bcm2835 =3D true; > #endif > hwrev =3D __uart_getreg(&sc->sc_bas, UART_PIDREG_2) >> 4; > if (hwrev <=3D 2 || is_bcm2835) { Sure. I'll report back either tonight or tomorrow. Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --wrrrn5gptp5ytu4l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAljEPWkACgkQaoRlj1JF bu5f7Q/9GypaIWvOGK715kufcfUNcYDFn85g4p1NxxXHupDx/INaonCjgXPZb2Rv vt3GvBC+imrq0vSsP1gyQ4YOBQ9Qirqlb+Q3qDTP93PFx/16hpWiRrvXIyik38vW tVHTefpCBfc9n7V+f3ExcBRRi95Nq8JAEEC7H+YBr6nWdxKNEIbF0Vx1gIuYPlNG MMMxFyPDoEjUwjxnVGDXNURH5hZ7gNv/JBcaDko4qqZbS2Yd1vMTF6nhyqrmstY1 7pPWV6ZD3pRZg3WiOTzFProwiedMS1YT64SjvuoV5CmKJyR/q68j9YrmKmK7Dgx/ Uv7GijDNSf2Q0oF/gUff/vjyhmAyQCsjCGyVgjkqpmB5mWEfbENAJYlLV6OLYr5Z dxPWThKAaT+dAgUTi4z+qida+9KCZTiggI2bU4kbh2IzuEOEmjnIzlWIoZxqOZ73 D8LQyHVzkmQkseSdYvdlT0SaeGxhQNkxoDqpF1dfmKyJT6FxyVVn/nQfOXNxUMah 8+d2sj2Jb3L0fWhlqUUMrCVaVjoGn+k/Er1appaA5ObngphReu6pZZjs8yrlzm34 ghwYut3PzPe5g/zKZ+8hp3P3DDvNkJfVPz4QPqIpdpGZrtWKmTj9ZELzy3gfgOv0 gLr9TWj9soTKCF+Bk7rSZ1OrYzLnp4hEFchuYyeNpPRoKVUjtNQ= =TBIY -----END PGP SIGNATURE----- --wrrrn5gptp5ytu4l--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170311180947.ro5obisuaemvudkp>