Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Jun 2015 19:41:21 +0000 (GMT)
From:      jenkins-admin@freebsd.org
To:        mjg@FreeBSD.org, br@FreeBSD.org, brooks@FreeBSD.org, marcel@FreeBSD.org,  kp@FreeBSD.org, ume@FreeBSD.org, jenkins-admin@FreeBSD.org,  freebsd-current@freebsd.org
Subject:   FreeBSD_HEAD - Build #2849 - Fixed
Message-ID:  <2001648946.112.1433965282863.JavaMail.jenkins@jenkins-9.freebsd.org>
In-Reply-To: <1710009091.108.1433944032889.JavaMail.jenkins@jenkins-9.freebsd.org>
References:  <1710009091.108.1433944032889.JavaMail.jenkins@jenkins-9.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
FreeBSD_HEAD - Build #2849 - Fixed:

Check console output at https://jenkins.freebsd.org/job/FreeBSD_HEAD/2849/ to view the results.
From owner-freebsd-current@FreeBSD.ORG  Wed Jun 10 20:14:06 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EAA614FD
 for <freebsd-current@freebsd.org>; Wed, 10 Jun 2015 20:14:06 +0000 (UTC)
 (envelope-from rmacklem@uoguelph.ca)
Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca
 [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id B5F621304
 for <freebsd-current@freebsd.org>; Wed, 10 Jun 2015 20:14:06 +0000 (UTC)
 (envelope-from rmacklem@uoguelph.ca)
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A2A9BABwmXhV/95baINchEmDGKx4jXYJgVKFfwqBdxQBAQEBAQEBgQqETIELAg0ZAl+IQZ5jj1+kCQEKAQEBHoEhjnSDI4FFBZB7pgAkggkdgW4igXeBAQEBAQ
X-IronPort-AV: E=Sophos;i="5.13,589,1427774400"; d="scan'208";a="215390780"
Received: from muskoka.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca)
 ([131.104.91.222])
 by esa-jnhn.mail.uoguelph.ca with ESMTP; 10 Jun 2015 16:13:59 -0400
Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1])
 by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id C2C28B4172
 for <freebsd-current@freebsd.org>; Wed, 10 Jun 2015 16:13:59 -0400 (EDT)
Date: Wed, 10 Jun 2015 16:13:59 -0400 (EDT)
From: Rick Macklem <rmacklem@uoguelph.ca>
To: freebsd current <freebsd-current@freebsd.org>
Message-ID: <1249942556.55526194.1433967239788.JavaMail.root@uoguelph.ca>
Subject: setting tunables in stable/10 vs head?
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.17.95.11]
X-Mailer: Zimbra 7.2.6_GA_2926 (ZimbraWebClient - FF3.0 (Win)/7.2.6_GA_2926)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>;
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jun 2015 20:14:07 -0000

Hi,

I just MFC'd a patch from head to stable/10 that defines some
tunables using CTLFLAG_RDTUN. Although the MFC didn't break
anything, the tunables don't get changed by the values in /boot/loader.conf.

By applying a patch like this:
 SYSCTL_DECL(_vfs_nfsd);
 int	nfsrv_statehashsize = NFSSTATEHASHSIZE;
+TUNABLE_INT("vfs.nfsd.statehashsize", &nfsrv_statehashsize);
 SYSCTL_INT(_vfs_nfsd, OID_AUTO, statehashsize, CTLFLAG_RDTUN,
     &nfsrv_statehashsize, 0,
     "Size of state hash table set via loader.conf");

they get set ok.

So, is this correct or have I done something stupid?

And, if it correct, do I commit a patch like the above directly
to stable/10. (It seems that TUNABLE_INT() is discouraged for -head.)

Thanks for any help with this, rick



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2001648946.112.1433965282863.JavaMail.jenkins>