Date: Fri, 31 Oct 1997 18:45:19 +0100 From: Wolfram Schneider <wosch@cs.tu-berlin.de> To: Bruce Evans <bde@zeta.org.au> Cc: Don.Lewis@tsc.tdk.com, wosch@cs.tu-berlin.de, freebsd-fs@FreeBSD.ORG, roberto@keltia.freenix.fr Subject: Re: disabled symlinks Message-ID: <19971031184519.12801@panke.de> In-Reply-To: <199710311325.AAA17135@godzilla.zeta.org.au>; from Bruce Evans on Sat, Nov 01, 1997 at 12:25:57AM %2B1100 References: <199710311325.AAA17135@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1997-11-01 00:25:57 +1100, Bruce Evans wrote: > >> } diff -u -r1.51.2.6 vfs_syscalls.c > >> } --- vfs_syscalls.c 1997/10/23 18:04:55 1.51.2.6 > >> } +++ vfs_syscalls.c 1997/10/30 22:24:47 > >> } @@ -1326,8 +1328,10 @@ > >> } return (error); > >> } vp = nd.ni_vp; > >> } error = vn_stat(vp, &sb, p); > >> } - if (vp->v_type == VLNK) > >> } + if (vp->v_type == VLNK && > >> } + (vp->v_mount->mnt_flag & MNT_NOSYMLINKFOLLOW) != 0) > > ^^ > > > >> This test looks backwards to me (it changes the behavior if the > >> new nosymlinkfollow option is not set). I'm also not clear as > >> to why the behaviour even depends on the option. > > It's also wrong because it breaks the setting of S_IFLNK. S_IFLNK was already set in vn_stat. -- Wolfram Schneider <wosch@apfel.de> http://www.apfel.de/~wosch/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19971031184519.12801>