Date: Wed, 27 Jan 1999 19:45:55 -0800 (PST) From: Archie Cobbs <archie@whistle.com> To: bde@zeta.org.au (Bruce Evans) Cc: wollman@khavrinen.lcs.mit.edu, current@FreeBSD.ORG Subject: Re: btokup() macro in sys/malloc.h Message-ID: <199901280345.TAA04081@bubba.whistle.com> In-Reply-To: <199901280251.NAA23946@godzilla.zeta.org.au> from Bruce Evans at "Jan 28, 99 01:51:15 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans writes: > >In fact, style(9) should say: > > > > If at all possible, your code should compile without warnings > > when the gcc -Wall flag is given. > > Avoiding warnings is more an engineering than a stylistic matter. > You turn on warnings to help avoid bugs that the compiler can find > easily. You ask everyone else to turn on warnings so that compiling > their sources with the same CFLAGS as your sources doesn't cause a > spew of warnings. Well said. Personally, it would take me twice as long to debug code without -Wall. > >As it stands now (and I QUOTE!) it says: > > > > Don't use parentheses unless they're required for precedence, or > > the statement is really confusing without them. > > > > a = b->c[0] + ~d == (e || f) || g && h ? i : j >> 1; > > > >That's ridiculous! > > I think it's trying to be funny. This makes it a bad example either > way. Perhaps its point is that complicated expressions can't be made > less confusing by adding parentheses. Guess I missed the joke then.. :-) You're right, some things are inherently complicated. I think line formatting is as importatn as parentheses, for example. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901280345.TAA04081>