Date: Sat, 18 Sep 1999 15:02:39 -0700 (PDT) From: Julian Elischer <julian@whistle.com> To: Poul-Henning Kamp <phk@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/vn vn.c Message-ID: <Pine.BSF.4.05.9909181455490.19879-100000@home.elischer.org> In-Reply-To: <199909182148.OAA88955@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning, since Matt (who is working on this driver) STATED that he didn't want you to do this, why did you do it anyway? If you want to do this right.. Move the calculation of blocksize in spec_read and spec_write to spec_open, and store the value in to si_bsize_best if it's still unset, and then in read/write just blindly use _best, instead of doing the calculation on every read and write. On Sat, 18 Sep 1999, Poul-Henning Kamp wrote: > phk 1999/09/18 14:48:39 PDT > > Modified files: > sys/dev/vn vn.c > Log: > Only assign to si_bsize_phys if we have an intelligent value for it. > Otherwise leave at zero and let the generic code decide. > > Revision Changes Path > 1.95 +1 -2 src/sys/dev/vn/vn.c > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9909181455490.19879-100000>