Date: Thu, 18 Nov 1999 13:21:16 -0500 (EST) From: Bill Fumerola <billf@chc-chimes.com> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Nick Hibma <hibma@skylink.it>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c vfs_vnops.c Message-ID: <Pine.BSF.4.10.9911181301200.46369-100000@jade.chc-chimes.com> In-Reply-To: <199911181814.KAA86275@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 18 Nov 1999, Matthew Dillon wrote: > I don't consider a simple PR reference to be proper credit, so I > put Kelly's name in the Submitted by: field (since he did submit it), > and since I reviewed it I put my name in the Reviewed by: field. > Sounds right to me. This has been discussed before. There is a long mail I sent out, but to summarize: All of those fields all pretty much mean "if it wasn't you". Hence, when I make a commit I don't say " Add a dependency to libfoo Submitted by: billf Reviewed by: billf " It's redundant. If you're committing, it's assumed you have reviewed the code. -- - bill fumerola - billf@chc-chimes.com - BF1560 - computer horizons corp - - ph:(800) 252-2421 - bfumerol@computerhorizons.com - billf@FreeBSD.org - To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9911181301200.46369-100000>