Date: Sun, 29 Oct 2000 00:27:54 +0100 From: Josef Karthauser <joe@pavilion.net> To: Tony Finch <dot@dotat.at> Cc: Matt Jacob <mjacob@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci isp_pci.c Message-ID: <20001029002754.I64763@pavilion.net> In-Reply-To: <20001026033147.B4137@hand.dotat.at>; from dot@dotat.at on Thu, Oct 26, 2000 at 03:31:47AM %2B0000 References: <200010250440.VAA41157@freefall.freebsd.org> <20001026033147.B4137@hand.dotat.at>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 26, 2000 at 03:31:47AM +0000, Tony Finch wrote: > Matt Jacob <mjacob@FreeBSD.org> wrote: > > > > Whoops! Forgot to commit this when I committed the other (turnin on locks) > > change. Sorry about that. > > It seems to me (based on my experience as an Apache core team member > and as someone who likes to understand software by looking at how it > evolved) that for the purposes of maintaining a useful history, > cockups like this should be handled by using the same commit message > when committing the missing file(s) as was used in the original > commit. Apologies should be posted separately or as an extra note > added to the original commit message, instead of replacing all useful > information with "whoops, sorry". I agree. There's a further benefit to this. The only way to determine what files were committed at the same time after the fact (excluding the commit mail logs) is to use a heuristic based on commit message, committer and fuzzy time of day. Please please use an exact copy of the commit message where possible otherwise the subsequent change will never be rolled into the first commit. Joe -- Josef Karthauser FreeBSD: How many times have you booted today? Technical Manager Viagra for your server (http://www.uk.freebsd.org) Pavilion Internet plc. [joe@pavilion.net, joe@uk.freebsd.org, joe@tao.org.uk] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001029002754.I64763>