Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 27 Feb 2001 21:03:41 +1100 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        Jeroen Ruigrok van der Werven <asmodai@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/etc/defaults make.conf
Message-ID:  <Pine.BSF.4.21.0102272056300.24660-100000@besplex.bde.org>
In-Reply-To: <200102270903.f1R93ta23067@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 27 Feb 2001, Jeroen Ruigrok van der Werven wrote:

> asmodai     2001/02/27 01:03:55 PST
> 
>   Modified files:
>     etc/defaults         make.conf 
>   Log:
>   Add -Wundef to BDECFLAGS:
>   
>   Warn if an undefined identifier is evaluated in an `#if' directive.
>   
>   Not objected to by:	bde

Actually, I do object to this.  It is idiomatic to use `#if FOO' instead
of `#ifdef FOO' if you are prepared to define FOO as nonzero if it is
defined at all (and you don't want FOO).

I also object to BDECFLAGS being defined unconditionally in
/etc/defaults/make.conf (unlike all the other namespace pollution
suggested there), not to mention the existence of BDECFLAGS (I
put the flags in a shell script) and the abuse of make.conf to
configure things other than make(1) :-).

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0102272056300.24660-100000>