Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Jul 2001 11:14:51 -0700
From:      Steve Kargl <sgk@troutmask.apl.washington.edu>
To:        "David O'Brien" <obrien@FreeBSD.ORG>
Cc:        Kris Kennaway <kris@obsecurity.org>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/usr.sbin/pkg_install/add main.c src/usr.sbin/pkg_install/lib str.c
Message-ID:  <20010728111451.A11416@troutmask.apl.washington.edu>
In-Reply-To: <20010728104814.A11239@dragon.nuxi.com>; from obrien@FreeBSD.ORG on Sat, Jul 28, 2001 at 10:48:14AM -0700
References:  <200107280159.f6S1xw810069@freefall.freebsd.org> <20010727204037.A58795@xor.obsecurity.org> <20010727214454.A96927@dragon.nuxi.com> <20010727222312.A3093@troutmask.apl.washington.edu> <20010728104814.A11239@dragon.nuxi.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 28, 2001 at 10:48:14AM -0700, David O'Brien wrote:
> On Fri, Jul 27, 2001 at 10:23:12PM -0700, Steve Kargl wrote:
> 
> > And, this commit seems to be a slap in the face of Kris. 
> 
> Why??  I saw inefficient coding done in the name of efficiency.  The last
> time I made such a commit I was asked to justify it.  So this time, I
> justified it in the commit message.  Would you prefer I didn't give a
> shit?

Read the commit log!  It is dripping with sarcasm.  Your code
may be better than what it replaced.  But, I'm sure you could
have written a more *professional* commit message without
implying the previous code must have been written by some
moron.

-- 
Steve

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010728111451.A11416>