Date: Sun, 16 Sep 2001 20:04:55 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: "David O'Brien" <obrien@FreeBSD.org> Cc: <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <20010916195045.X34241-100000@delplex.bde.org> In-Reply-To: <20010915165402.A84034@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 15 Sep 2001, David O'Brien wrote: > On Sun, Sep 16, 2001 at 06:15:45AM +1000, Bruce Evans wrote: > > I now prefer something like: > > > > --- > > <copyright comment> > > > > #if 0 /* maybe change to #ifdef VENDOR_ID */ > > <vendor id stuff> > > #endif > > > > #include <sys/cdefs.h> > > __FBSDID($NetBSD$) > > --- > > Why do we need to "#if 0" out NetBSD's __RCSID's? Our macros handle them > just fine. Thus we would only be adding __FBSDID() to such code. "#if 0" is more general and easier to add, and I want to make it clear that the vendor ids are intentionally left out. > Is it OK to only comment out non-__RCSID using code? Doing it your way, > adds more of our changes around possible Vendor code -- CVS will barf > harder in the face of that. It's not only OK, it's usually necessary. I think it's less than useful to have a special way of handling the few percent of files that have NetBSD-style __RCSIDs. Most vendor ids are still from Berkeley, and look like: #if defined(LIBC_SCCS) && !defined(lint) static char sccsid[] = "@(#)alarm.c 8.1 (Berkeley) 6/4/93"; #endif /* LIBC_SCCS and not lint */ in libraries, and: #ifndef lint static char sccsid[] = "@(#)cat.c 8.2 (Berkeley) 4/27/95"; #endif /* not lint */ in utilities. The ones (like the above) in libraries are already ifdefed out if we avoid defining LIBC, but in the most common case of utilities there is only the lint ifdef so we would need to add an ifdef to disable these ids. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010916195045.X34241-100000>