Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 15 Sep 2001 16:54:02 -0700
From:      "David O'Brien" <obrien@FreeBSD.org>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/share/man/man9 style.9
Message-ID:  <20010915165402.A84034@dragon.nuxi.com>
In-Reply-To: <20010916054620.T29957-100000@delplex.bde.org>; from bde@zeta.org.au on Sun, Sep 16, 2001 at 06:15:45AM %2B1000
References:  <20010915121926.A71700@dragon.nuxi.com> <20010916054620.T29957-100000@delplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 16, 2001 at 06:15:45AM +1000, Bruce Evans wrote:
> I now prefer something like:
> 
> ---
> <copyright comment>
> 
> #if 0 /* maybe change to #ifdef VENDOR_ID */
> <vendor id stuff>
> #endif
> 
> #include <sys/cdefs.h>
> __FBSDID($NetBSD$)
> ---

Why do we need to "#if 0" out NetBSD's __RCSID's?  Our macros handle them
just fine.  Thus we would only be adding __FBSDID() to such code.
Is it OK to only comment out non-__RCSID using code?  Doing it your way,
adds more of our changes around possible Vendor code -- CVS will barf
harder in the face of that.
 
-- 
-- David  (obrien@FreeBSD.org)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010915165402.A84034>