Date: Sat, 29 Dec 2001 12:50:25 +0000 From: David Malone <dwmalone@maths.tcd.ie> To: "David E. O'Brien" <obrien@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.sys.mk Message-ID: <20011229125025.A44606@walton.maths.tcd.ie> In-Reply-To: <200112150602.fBF62FH73911@freefall.freebsd.org>; from obrien@FreeBSD.org on Fri, Dec 14, 2001 at 10:02:15PM -0800 References: <200112150602.fBF62FH73911@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 14, 2001 at 10:02:15PM -0800, David E. O'Brien wrote:
> obrien 2001/12/14 22:02:15 PST
>
> Modified files:
> share/mk bsd.sys.mk
> Log:
> Add some granularity to the WARNS levels.
> 1: add -Werror
> 2: -Wall [only], as this is the most used warnings setting by developers
> 3: our old `1'
> 4: our old `2'
WARNS=4 doesn't seem to be the same as WARNS=2 used to be, because
-Wno-uninitialized isn't getting added at the end of the warnings
flags and so -Wuninitialized is still producing false positives.
Could someone review the patch below?
Also, if we fiddle further with the meaning of WARNS levels, it may
make sense to number them as if we were basic programmers?
David.
Index: /usr/src/share/mk//bsd.sys.mk
===================================================================
RCS file: /cvs/FreeBSD-CVS/src/share/mk/bsd.sys.mk,v
retrieving revision 1.4
diff -u -r1.4 bsd.sys.mk
--- /usr/src/share/mk//bsd.sys.mk 15 Dec 2001 06:02:15 -0000 1.4
+++ /usr/src/share/mk//bsd.sys.mk 29 Dec 2001 12:41:10 -0000
@@ -15,15 +15,17 @@
. endif
. if ${WARNS} > 1
CFLAGS += -Wall
-# XXX Delete -Wuninitialized by default for now -- the compiler doesn't
-# XXX always get it right.
-CFLAGS += -Wno-uninitialized
. endif
. if ${WARNS} > 2
CFLAGS += -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
. endif
. if ${WARNS} > 3
CFLAGS += -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align
+. endif
+. if ${WARNS} > 1
+# XXX Delete -Wuninitialized by default for now -- the compiler doesn't
+# XXX always get it right.
+CFLAGS += -Wno-uninitialized
. endif
. endif
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011229125025.A44606>