Date: Thu, 09 May 2002 07:26:08 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Bruce Evans <bde@zeta.org.au> Subject: Re: cvs commit: src/sbin/sysctl sysctl.c Message-ID: <XFMail.20020509072608.jhb@FreeBSD.org> In-Reply-To: <20020509082303.GA2131@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09-May-2002 Andrey A. Chernov wrote: > On Thu, May 09, 2002 at 15:25:11 +1000, Bruce Evans wrote: >> > > > Revision Changes Path >> > > > 1.45 +1 -1 src/sbin/sysctl/sysctl.c >> > > >> > > This overruns the buffer in the (unlikely) even that sysctl(3) returned >> > > a >> > > full buffer. >> > >> > Do you saw j += j there? Buffer is doubled (unless I misunderstand this >> > thing). >> >> Yes; that is why I wrote that the even[t] is unlikely. We double the buffer >> size in case the name expands underneath us. If the name actually expands >> by a full factor of 2, we overrun the buffer. > > In any case this problem not with my commit :-) It's still a bug that should be fixed, which is Bruce's point I think. Not all of Bruce's e-mails point out bugs in your code. Often times he is pointing out other bugs in the code hoping you will fix them since you have demonstrated some level of interest in the code. Fixing bugs is good. :) -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020509072608.jhb>