Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 May 2002 08:09:53 +0400
From:      "Andrey A. Chernov" <ache@nagual.pp.ru>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sbin/sysctl sysctl.c
Message-ID:  <20020509040953.GA894@nagual.pp.ru>
In-Reply-To: <20020509134229.N3451-100000@gamplex.bde.org>
References:  <200205082349.g48NnK708651@freefall.freebsd.org> <20020509134229.N3451-100000@gamplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 09, 2002 at 13:50:37 +1000, Bruce Evans wrote:
> On Wed, 8 May 2002, Andrey A. Chernov wrote:
> 
> > ache        2002/05/08 16:49:20 PDT
> >
> >   Modified files:
> >     sbin/sysctl          sysctl.c
> >   Log:
> >   Don't forget to null-terminate string we got from sysctl (f.e. in 'A' format).
> >   Stack garbadge may be printed otherwise.
> >
> >   Revision  Changes    Path
> >   1.45      +1 -1      src/sbin/sysctl/sysctl.c
> 
> This overruns the buffer in the (unlikely) even that sysctl(3) returned a
> full buffer.

Do you saw j += j there? Buffer is doubled (unless I misunderstand this 
thing).

-- 
Andrey A. Chernov
http://ache.pp.ru/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020509040953.GA894>