Date: Sun, 23 Jun 2002 01:21:25 -0500 From: Alan Cox <alc@cs.rice.edu> To: Alfred Perlstein <bright@mu.org> Cc: Alan Cox <alc@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_mmap.c Message-ID: <20020623062125.GH19727@cs.rice.edu> In-Reply-To: <20020623052710.GK53232@elvis.mu.org> References: <200206230148.g5N1mN795443@freefall.freebsd.org> <20020623052710.GK53232@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 22, 2002 at 10:27:10PM -0700, Alfred Perlstein wrote: > * Alan Cox <alc@FreeBSD.org> [020622 18:48] wrote: > > alc 2002/06/22 18:48:23 PDT > > > > Modified files: > > sys/vm vm_mmap.c > > Log: > > o Remove the unnecessary acquisition and release of Giant around fdrop() > > in mmap(2). > > I think fdrop() may need Giant in case a race with a thread makes > it the instance of fdrop() that leads to fclose() being called which > can call down into the VFS code. > fdrop_locked(), which is called by fdrop(), acquires and releases Giant in the scenario that you describe. Alan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020623062125.GH19727>