Date: Wed, 7 Aug 2002 10:28:56 -0500 From: Chris Costello <chris@FreeBSD.org> To: Robert Watson <rwatson@FreeBSD.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 15640 for review Message-ID: <20020807152856.GB1620@holly.calldei.com> In-Reply-To: <200208071501.g77F1kqX000349@freefall.freebsd.org> References: <200208071501.g77F1kqX000349@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, August 07, 2002, Robert Watson wrote: > Fix (I believe) support for the trusted_interfaces variable by > bzero'ing a buffer in the stack to truncate strings by default. > > Differences ... > > ==== //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#94 (text+ko) ==== > > @@ -980,6 +980,7 @@ > !strvalid(trusted_interfaces, sizeof(trusted_interfaces))) > goto set; > > + bzero(tiflist, sizeof(tiflist)); > for (p = trusted_interfaces, q = tiflist; *p != '\0'; p++, q++) > if(*p != ' ' && *p != '\t') > *q = *p; I wonder if just placing *++p = '\0'; wouldn't be better and/or faster, instead of zeroing the whole thing beforehand... -- Chris Costello <chris@FreeBSD.org> FreeBSD Project http://www.FreeBSD.org/ TrustedBSD Project http://www.TrustedBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020807152856.GB1620>