Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 23 Aug 2002 11:34:21 -0400 (EDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Brian Feldman <green@FreeBSD.org>
Cc:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   RE: PERFORCE change 16462 for review
Message-ID:  <XFMail.20020823113421.jhb@FreeBSD.org>
In-Reply-To: <200208231405.g7NE5dOK067653@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 23-Aug-2002 Brian Feldman wrote:
> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=16462
> 
> Change 16462 by green@green_laptop_2 on 2002/08/23 07:04:41
> 
>       * Don't grab Giant implicitly in mac_cred_mmapped_drop_perms(9).
>       * Select a good default label (read: "equal") for tty devices.
>       * Don't crhold(9) before calling crcopy(9) due to undocumented
>         reference-count assertions.

Eh, crcopy() doesn't change the reference count.  However, since we have
to bump reference counts on things like uidinfo's, etc. it needs to ensure
that you only do a crcopy() onto a "blank" ucred.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020823113421.jhb>