Date: Wed, 23 Apr 2003 03:30:16 +0900 (JST) From: Hiroki Sato <hrs@eos.ocn.ne.jp> To: simon@nitro.dk Cc: doc@freebsd.org Subject: Re: suggestion for adding a l10n-capable doc-format navi Message-ID: <20030423.033016.07643305.hrs@eos.ocn.ne.jp> In-Reply-To: <20030420113210.GA390@nitro.dk> References: <200304191749.h3JHndxV053505@bmah.dyndns.org> <20030420.195205.50333554.hrs@eos.ocn.ne.jp> <20030420113210.GA390@nitro.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
"Simon L. Nielsen" <simon@nitro.dk> wrote
in <20030420113210.GA390@nitro.dk>:
simon> I think it would be more intuitive if setting a make variable to NO
simon> really disabled the variable in all the FreeBSD makefiles but since it
simon> doesn't I think it is more or less impossible to remember when using NO
simon> is ok and when it is not.
simon>
simon> I know this seems like a bike shed (and probably is a bit) but I think
simon> consitency is rather important.
Finally I have committed:
- when WITH_DOCFORMAT_NAVI_LINK is defined, the navi-link is generated
regardless of what the value was.
- when WITH_DOCFORMAT_NAVI_LINK is not defined,
the navi-link is not generated, but if ${FORMATS} includes
"html" and "html-split" simultaneously, it is generated.
"NO_FOO and WITH_FOO" way has another problem; which has priority.
And I think it is overdoing in this case.
--
| Hiroki SATO <hrs@eos.ocn.ne.jp> / <hrs@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030423.033016.07643305.hrs>