Date: Mon, 21 Apr 2003 13:22:00 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Marcel Moolenaar <marcel@FreeBSD.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: RE: PERFORCE change 29330 for review Message-ID: <XFMail.20030421132200.jhb@FreeBSD.org> In-Reply-To: <200304210513.h3L5DwwN098360@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21-Apr-2003 Marcel Moolenaar wrote: > http://perforce.freebsd.org/chv.cgi?CH=29330 > > Change 29330 by marcel@marcel_nfs on 2003/04/20 22:13:14 > > Remove the debugging printf and invert the condition so that the > flow of control is slightly less weird. > > Affected files ... > > .. //depot/projects/ia64_epc/sys/ia64/ia64/trap.c#11 edit > > Differences ... > > ==== //depot/projects/ia64_epc/sys/ia64/ia64/trap.c#11 (text+ko) ==== > > @@ -317,12 +317,10 @@ > { > while (1) { > disable_intr(); > - if (curthread->td_flags & (TDF_ASTPENDING|TDF_NEEDRESCHED)) { > - enable_intr(); > - printf("XXX calling ast()\n"); > - ast(tf); > - } else > + if (!(curthread->td_flags & (TDF_ASTPENDING|TDF_NEEDRESCHED))) > break; > + enable_intr(); > + ast(tf); > } > /* Keep interrupts disabled. */ > } Perhaps: disable_intr(); while (curthread->td_flags & (TDF_ASTPENDING|TDF_NEEDRESCHED)) { enable_intr(); ast(tf); disable_intr(); } would be even clearer? :) -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030421132200.jhb>