Date: Thu, 26 Jun 2003 20:40:37 -0500 (CDT) From: Archie Cobbs <archie@dellroad.org> To: Doug Lee <dgl@dlee.org> Cc: Archie Cobbs <archie@dellroad.org> Subject: Re: Possible Solution (Re: mpd VPN won't work after upgrade from4.6-STABLE to 4.8-STABLE) Message-ID: <200306270140.h5R1ecCk009051@arch20m.dellroad.org> In-Reply-To: <20030627013054.GA42511@kirk.dlee.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Doug Lee wrote:
> Re: the "protocol reject" errors; I left the original messages below
> this for reference, but I'm not so much following directly onto
> them...
>
> Archie, I'm mildly embarrassed. I just now found something you wrote
> in November of last year advising the following patch to fix exactly
> this problem. I am running two 4.8-STABLE boxen, and it is not part
> of /sys/netgraph/ng_ppp.c in CVS yet, apparently...
>
> --- sys/netgraph/ng_ppp.c.orig Thu Nov 21 12:39:06 2002
> +++ sys/netgraph/ng_ppp.c Thu Nov 21 12:39:26 2002
> @@ -744,7 +744,7 @@
> case HOOK_INDEX_VJC_VJIP:
> if (priv->conf.enableCompression
> && priv->hooks[HOOK_INDEX_COMPRESS] != NULL) {
> - if ((m = ng_ppp_addproto(m, proto, 1)) == NULL) {
> + if ((m = ng_ppp_addproto(m, proto, 0)) == NULL) {
> NG_FREE_META(meta);
> return (ENOBUFS);
> }
> I patched ng_ppp.c, but I don't know if I can rebuild netgraph without
> a make world, which takes a good 12 hours on this P166... advice on
> that welcome.
All you need to do is rebuild/reinstall your kernel+modules.
> Should one of us submit a PR for this, or did I miss something?
This is (arguably) a bug in whatever is running on the other side
of your link (it's not FreeBSD, right?). So that's why it was never
checked in (because it's a workaround that costs an extra byte in
every packet). However, you could argue that it should be I guess...
-Archie
__________________________________________________________________________
Archie Cobbs * Halloo Communications * http://www.halloo.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200306270140.h5R1ecCk009051>