Date: Fri, 18 Jun 2004 18:04:02 -0400 From: Brian Fundakowski Feldman <green@FreeBSD.org> To: Alan Cox <alc@cs.rice.edu> Cc: peter@FreeBSD.org Subject: Re: contigmalloc(9) rewrite Message-ID: <20040618220402.GB27588@green.homeunix.org> In-Reply-To: <20040618212127.GS6753@cs.rice.edu> References: <20040615195709.GE1016@green.homeunix.org> <20040618205115.GA27588@green.homeunix.org> <20040618212127.GS6753@cs.rice.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 18, 2004 at 04:21:27PM -0500, Alan Cox wrote: > On Fri, Jun 18, 2004 at 04:51:15PM -0400, Brian Fundakowski Feldman wrote: > > On Tue, Jun 15, 2004 at 03:57:09PM -0400, Brian Fundakowski Feldman wrote: > > > The patch, which applies to 5-CURRENT, can be found here: > > > <http://green.homeunix.org/~green/contigmalloc2.patch>; > > > The default is to use the old contigmalloc(). You can set the > > > sysctl or loader tunable "vm.old_contigmalloc" to 0 to enable it. > > > > > > For anyone that normally runs into failed allocations hot-plugging > > > hardware, please try this and see if it helps out. > > > > By the way, I have updated it further to split apart contigmalloc() > > into a separate vm_page_alloc_contig() and mapping function as per > > feedback from Alan Cox and Hiten Pandya. The operation is still the > > same except for now being able to see memory allocated with it > > in your vmstat(8) -m output. The patch is still at the same location, > > and requires sysctl vm.old_contigmalloc=0 to enable. > > > > Why don't you commit the part that makes allocation of physical memory > start from high addresses? I don't think it's very useful fixing the very broken vm.old_contigmalloc=1 anymore, but if someone else would like to do it, I certainly won't object to it. Just that change in behavior isn't useful to what is probably the majority of users for which the low and high arguments to contigmalloc() aren't used. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040618220402.GB27588>