Date: Fri, 7 Jan 2005 21:02:57 -0500 (EST) From: fox@vader.aacc.cc.md.us To: Volker Stolz <vs@freebsd.org> Cc: freebsd-ports-bugs@freebsd.org Subject: Re: ports/75890: Port net/tkabber breaks "make index" under 4.8 Message-ID: <Pine.LNX.4.60.0501072048530.25625@vader.aacc.edu> In-Reply-To: <20050107082334.GA42289@i2.informatik.rwth-aachen.de> References: <200501061748.j06HmgfF058433@www.freebsd.org> <20050107082334.GA42289@i2.informatik.rwth-aachen.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 7 Jan 2005, Volker Stolz wrote: > In gmane.os.freebsd.devel.ports.bugs, you wrote: >>> Description: >> 4.x make(1) doesn't understand -C before src/usr.bin/make/main.c 1.35.2.9 (RELENG_4_9). >> This causes "make index" in /usr/ports to fail, among other things. >> >> COMMENT= Tcl/Tk based jabber client >> >> -TCLLIBVER!= ${MAKE} -C ${.CURDIR}/../../devel/tcllib -V PORTVERSION >> +TCLLIBVER!= ${MAKE} -C ${.CURDIR}/../../devel/tcllib -V PORTVERSION 2>/dev/null \ >> + || (cd ${.CURDIR}/../../devel/tcllib; ${MAKE} -V PORTVERSION) > > Shouldn't it be sufficient to *always* use the latter construct? Hmm... I think it would be now, but it's not guaranteed to remain that way. The second operand of || may not do the same as the first in versions (current or future) of make that understand -C. Also, written this way, it makes it obvious it's a workaround until versions of FreeBSD with a make that doesn't grok -C go away. (meaning 4.8 and below) -- "I'd ask if you'd found the right sort of isolated wasteland for your citadel of dread yet, but that would be a silly question; you're in Utah, after all." --ESR to Darl McBride (Chief Excessive Ossifier of Squandered Clues Obstination), in http://www.catb.org/~esr/writings/mcbride.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.4.60.0501072048530.25625>