Date: Tue, 08 Mar 2005 06:18:29 -0800 From: "Michael C. Shultz" <ringworm01@gmail.com> To: Michael Nottebrock <michaelnottebrock@gmx.net> Cc: freebsd-ports@freebsd.org Subject: Re: imlib2 port broken on RELENG_4? Message-ID: <200503080618.31094.ringworm01@gmail.com> In-Reply-To: <200503081152.54237.michaelnottebrock@gmx.net> References: <1110223267.1739.64.camel@think> <20050308094914.GA58071@fatpipi.cirx.org> <200503081152.54237.michaelnottebrock@gmx.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 08 March 2005 02:52 am, you wrote:
> On Tuesday, 8. March 2005 10:49, Vanilla I. Shu wrote:
> > On Tue, Mar 08, 2005 at 10:19:10AM +0100, Michael Nottebrock wrote:
> > > On Tuesday, 8. March 2005 00:11, Michael C. Shultz wrote:
> > > > ../../src/lib/.libs/libImlib2.so: undefined reference to
> > > > `round'
> > >
> > > So replace round() with rint() as well (no extra cast required).
> >
> > thanks.
>
> Uh, sorry, that reply was kinda bogus, I didn't read the whole
> thread.
>
> round() isn't in 4.x either and the extra cast for lround to rint is
> correct of course.
>
> Here's a complete patch for imlib2, tested on 4.11. Note that it's
> not worth the effort to conditionalize the patch on OSVERSION, since
> [l]lround[f] have only been very recently added to FreeBSD. Better
> add a configure-check for lround and some rounding-macro to the
> upstream sources (I've done that a lot in KDE recently, too).
I just cvsup'ed and see that Mr. Shu has allready added a
post-patch:
@${REINPLACE_CMD} -e \
's|lround|(long int)rint|g'
${WRKSRC}/src/lib/color_helpers.c
So looks like it is fixed. imglib2 compiles fine for me on 4.11 and 5.4
now so thanks Michael for the solution. :)
-Mike
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200503080618.31094.ringworm01>